Segmentation fault on run about stag

[eigengrau]

I too am getting an immediate segfault since updating from 9de521d to f199913. The segfault even occurs when running without any parameters or input, and also when piping data into the process.

I ran it through gdb:

(gdb) run
Starting program: /usr/bin/stag 
Got object file from memory but can't read symbols: File truncated.
warning: Could not load shared library symbols for linux-vdso.so.1.
Do you need "set solib-search-path" or "set sysroot"?

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff75f6174 in __strcmp_ssse3 () from /usr/lib/libc.so.6
(gdb) bt
#0  0x00007ffff75f6174 in __strcmp_ssse3 () from /usr/lib/libc.so.6
#1  0x00000000004013b6 in main ()

I’m not a C coder, but I’ve never had the «truncated file» message before in gdb. Any idea what that might mean? Google didn’t really help. The message seems a bit odd; the file is unstripped, but I don’t think that’s what it’s about.

[eigengrau]

It seems the Makefile overrode my CFLAGS, that’s why I had no line numbers. Here’s a new BT.

(gdb) run
Starting program: /tmp/makepkg/stag-graph-git/src/stag-graph/stag 
Got object file from memory but can't read symbols: File truncated.
warning: Could not load shared library symbols for linux-vdso.so.1.
Do you need "set solib-search-path" or "set sysroot"?

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff75f6174 in __strcmp_ssse3 ()
   from /usr/lib/libc.so.6
(gdb) bt
#0  0x00007ffff75f6174 in __strcmp_ssse3 ()
   from /usr/lib/libc.so.6
#1  0x00000000004013b6 in main (argc=1, argv=0x7fffffffdf98)
    at stag.c:69

Still says «file truncated» though.

[eigengrau]

So I suppose the problem is strcmp(argv[1], "--help") == 0, which segfaults when no switches are set?

[seenaburns]

Awesome work @eigengrau, that was exactly it.

Fixed in 1f010a1