Comments (7)
We call in track just a line above https://github.com/segmentio/analytics-android/blob/master/analytics/src/main/java/com/segment/android/integrations/MixpanelIntegration.java#L129.
The code you linked tracks a charge only the revenue is defined.
from analytics-android.
That would be correct if I was calling an event.I am calling screen which
is calling event for mixpanel.
On Jul 10, 2014 4:17 PM, "Prateek Srivastava" [email protected]
wrote:
We call in track just a line above
https://github.com/segmentio/analytics-android/blob/master/analytics/src/main/java/com/segment/android/integrations/MixpanelIntegration.java#L129
.The code you linked tracks a charge only the revenue is defined.
—
Reply to this email directly or view it on GitHub
#58 (comment)
.
from analytics-android.
What should it be calling instead? Mixpanel only supports track as far as I can see. We simply proxy the screen calls to their track since that's what they support.
I'm also not sure where your'e thinking that we send a screen event only for revenue in the code you posted.
from analytics-android.
@naqi Do you still think this is the wrong behavior? What do you expect the right one to be?
from analytics-android.
@f2prateek I ended up making the changes myself. Will send a pull request some time after this week.
from analytics-android.
@naqi Sweet!
from analytics-android.
@naqi Mind sharing the changes? We wanted to verify what the behaviour should be, and correct our iOS project too since this is what we do there as well.
from analytics-android.
Related Issues (20)
- ANR for Utils.java HOT 1
- Utils.isEmptyOrBlank causes NullPointerException HOT 1
- How to send the Application Crashed event HOT 3
- Do we need to upgrade integration SDKs? (ref: Device ID Collection Circumvents Google Play User Data Policy) HOT 7
- Could use integrations: {"mixpanel": false} to avoid event get into Mixpanel? HOT 2
- Crash: Unable to collect advertising ID from Google Play Services.
- Analytics is crashing in the background after updating from 4.3.0 to 4.10.1 HOT 2
- kotlinx.serialization.SerializationException: Serializer for class 'Traits' is not found. HOT 1
- Document around `Analytics.Builder.collectDeviceId()` is outdated? HOT 1
- When we are making normal apk its working fine, but if create build from github this error is coming.
- Documentation for device.token is outdated HOT 2
- Creating empty payload with comma's while uploading HOT 1
- PlayStore rejecting app due to non-compliant with Google Play Policies HOT 20
- Setting a custom api host defaults in api.segment.io/v1 url
- Segment with Intercom HOT 6
- ANR triggered by thread waiting for a binder transaction HOT 1
- User identify tracking HOT 3
- Can not init Segment for 4.11.2 HOT 5
- StrictMode violations on Segment initialization HOT 2
- Unsafe.park , NullPointerException in Utils.java HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from analytics-android.