GithubHelp home page GithubHelp logo

Comments (7)

f2prateek avatar f2prateek commented on May 18, 2024

We call in track just a line above https://github.com/segmentio/analytics-android/blob/master/analytics/src/main/java/com/segment/android/integrations/MixpanelIntegration.java#L129.

The code you linked tracks a charge only the revenue is defined.

from analytics-android.

naqi avatar naqi commented on May 18, 2024

That would be correct if I was calling an event.I am calling screen which
is calling event for mixpanel.
On Jul 10, 2014 4:17 PM, "Prateek Srivastava" [email protected]
wrote:

We call in track just a line above
https://github.com/segmentio/analytics-android/blob/master/analytics/src/main/java/com/segment/android/integrations/MixpanelIntegration.java#L129
.

The code you linked tracks a charge only the revenue is defined.


Reply to this email directly or view it on GitHub
#58 (comment)
.

from analytics-android.

f2prateek avatar f2prateek commented on May 18, 2024

What should it be calling instead? Mixpanel only supports track as far as I can see. We simply proxy the screen calls to their track since that's what they support.

I'm also not sure where your'e thinking that we send a screen event only for revenue in the code you posted.

from analytics-android.

f2prateek avatar f2prateek commented on May 18, 2024

@naqi Do you still think this is the wrong behavior? What do you expect the right one to be?

from analytics-android.

naqi avatar naqi commented on May 18, 2024

@f2prateek I ended up making the changes myself. Will send a pull request some time after this week.

from analytics-android.

f2prateek avatar f2prateek commented on May 18, 2024

@naqi Sweet!

from analytics-android.

f2prateek avatar f2prateek commented on May 18, 2024

@naqi Mind sharing the changes? We wanted to verify what the behaviour should be, and correct our iOS project too since this is what we do there as well.

from analytics-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.