GithubHelp home page GithubHelp logo

Comments (2)

seiffert avatar seiffert commented on July 27, 2024

Thanks for the input! In fact, I haven't seen this change so far.

I'm not really opinionated about whether all commands should be defined as services. If one does not override Bundle::registerCommands, the commands that don't have dependencies should be registered by the default mechanism. If one of those commands is defined as service as well, it should be re-registered, which shouldn't have any effect (I haven't had the chance to test this, yet). If a command is not defined as a service, it will be registered only once.
This way, everybody's requirements should be fulfilled, right? If so, I will just remove the section where Bundle::registerCommands is overridden from the README. Also, feel free to submit PRs for such small changes ;-)

from console-extra-bundle.

havvg avatar havvg commented on July 27, 2024

Well, I wasn't sure, how to handle it, therefore no PR yet :-)

The only thing I could come up with would be optional "dependencies", like setLogger or similar, where you would want to not have the same command registered twice (which afaik would fail).

from console-extra-bundle.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.