GithubHelp home page GithubHelp logo

Unable to add styles about universal-react HOT 7 OPEN

sekoyo avatar sekoyo commented on August 16, 2024
Unable to add styles

from universal-react.

Comments (7)

jturbo26 avatar jturbo26 commented on August 16, 2024

Hey @greygatch - I don't think it's this boilerplate's fault. You're only using a SCSS loader but you also need the CSS loader and the Style loader. The SCSS loader only converts SCSS to CSS, but webpack still needs to be able to read CSS.

from universal-react.

DominicTobias avatar DominicTobias commented on August 16, 2024

from universal-react.

greygatch avatar greygatch commented on August 16, 2024

@jturbo26 @DominicTobias

You're only using a SCSS loader but you also need the CSS loader and the Style loader

I don't understand. Am I not chaining the loaders together and using all three?

loader: 'style-loader!css-loader!sass-loader',

This is an old style to use multiple loaders, but it is supported.

from universal-react.

DominicTobias avatar DominicTobias commented on August 16, 2024

Hm yeah I replied via email and didn't see the original post, looks correct so I'm not sure where the problem is, but there's nothing specific in this repo preventing it.

What's more likely is that this is the Node process encountering the scss import and Node doesn't know what to do with it. Try adding at the top of server.js:

require.extensions['.scss'] = () => {};

from universal-react.

jturbo26 avatar jturbo26 commented on August 16, 2024

@greygatch Yep. My bad. I don't know how I didn't see that chain.

from universal-react.

greygatch avatar greygatch commented on August 16, 2024

@jturbo26 Just to make sure it didn't break with the new webpack release, I updated it to the new way.

Maybe it has something to do with the universal rendering?

{
    test: /\.scss$/,
    use: [
         'style-loader',
         'css-loader',
         'sass-loader'
    ],
    include: path.join(__dirname, 'app')
}

from universal-react.

jturbo26 avatar jturbo26 commented on August 16, 2024

I don't think it's the universal rendering because I was able to get css to load. Are you sure you've installed all your loaders with npm install?

I don't use SASS, but I was able to get CSS modules working very easily. Here's part of my webpack config to compare.

module: {
    rules: [
      {
        test: /\.js?$/,
        use: 'babel-loader',
        include: path.join(__dirname, 'app'),
      },
      { test: /\.jsx$/, use: 'babel-loader', exclude: /node_modules/ },
      {
        test: /\.css?$/,
        use: [
          'style-loader',
          {
            loader: 'css-loader',
            options: {
              modules: true,
              localIdentName: '[name]_[local]_[hash:base64:5]',
            },
          },
        ],
      },
    ],
  },

from universal-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.