GithubHelp home page GithubHelp logo

Comments (5)

lsf37 avatar lsf37 commented on July 18, 2024 1

So, playing around with it a bit locally, the latest version of autopep8 does upgrade one dependency which doesn't seem to be a problem, and it does have impact on a small number of our python files, but everything I have seen are actual fixes that it should have done that way in the first place.

So I'd be up for bumping that version.

Still need to investigate cmake-format.

@Ivan-Velickovic I remember you having trouble with autopep8 crashing -- would that potentially be alleviated by bumping the style checks to the latest version? Or do you expect more trouble from that?

from ci-actions.

Ivan-Velickovic avatar Ivan-Velickovic commented on July 18, 2024 1

I can't remember exactly but based on this seL4/microkit#67 (comment) comment I think it was fine. Using the newer version didn't (at least for that code) do a bunch of incompatible/extra styling so at least for my purposes upgrading the version shouldn't cause trouble.

from ci-actions.

lsf37 avatar lsf37 commented on July 18, 2024

It looks like what we need is autopep8 v2.0.4 (which is currently the latest). The package sel4-deps in the seL4 repo sets autopep8==1.4.3.

Not sure if there will be flow-on effects from that, but we could upgrade that.

from ci-actions.

lsf37 avatar lsf37 commented on July 18, 2024

The same package also pins cmake-format, which from time to time was showing stupid formatting. Could try to upgrade that too, but all of this may lead to style failures. Hopefully only at the points that previously were stupid, but we should probably at least try to check if those versions do something fundamentally different.

from ci-actions.

lsf37 avatar lsf37 commented on July 18, 2024

Result of playing with cmake-format versions: their output differs fairly strongly. If we decide to upgrade, that should definitely be a separate discussion and needs to be weighed carefully against the noise it is going to produce in commits. The latest version is 0.6.13. Development seems to have slowed down, at least there hasn't been a new version since 2021 (and plenty before). That version has slightly different config options with more customisability, so it might be possible to get something nicer for those cases that are currently annoying, but at least in < 15min I wasn't able to find a combination that produces only small diffs to what we have now.

So: separate discussion for cmake-format, and if nobody objects, I would upgrade autopep8 to the latest version which fixes some crashes and seems mostly layout-stable. Pinging @seL4/tsc in case people want to weigh in on that.

from ci-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.