GithubHelp home page GithubHelp logo

Comments (7)

daltones avatar daltones commented on September 4, 2024

Good point. I made another template myself.

Actually that LESS template is not working at all. Those syntaxes to get array itens are wrong.

from node-sprite-generator.

selaux avatar selaux commented on September 4, 2024

@alberto-bottarini: True, that was a bit short sighted by me. It basically stems from me, wanting to keep all the css-preprocessors as similar as possible with the least possible hassle. I will have to look into how all the css-prerocessors handle units before fixing this.

@daltones: I know it's annoying if you want to use a software and it's not working, but if you knew that the less template is broken and needed to write your own, why don't you contribute parts of your template back or open an issue about it? Just mentioning it in a sentence in another issue micht not be the best way to bring that to my attention.

from node-sprite-generator.

selaux avatar selaux commented on September 4, 2024

@alberto-bottarini, @daltones : Can you try out the fix-stylesheet-variables-being-strings branch and check wether the the variables (and array indexing) work as expected in this branch? If so, I will merge and release 0.8.1 asap. 🍻

from node-sprite-generator.

daltones avatar daltones commented on September 4, 2024

@selaux, you're right. I'm sorry if my reply seems like rude. Actually my intention was to contribute later, I was working at that time.

I will write a fix today.

from node-sprite-generator.

alberto-bottarini avatar alberto-bottarini commented on September 4, 2024

I did some test with LESS and now it seems more usable.
I can now use all the auto-generated variables also in other contexts.

I'll wait for 0.8.1 👍

from node-sprite-generator.

selaux avatar selaux commented on September 4, 2024

@alberto-bottarini: Cool, I will merge this then

@daltones: No offense taken 😉, it's just that I only test all the stylesheet generators by using a online converter (i use http://less2css.org/ for less) and there it worked. To get to know that one of them does not work at all was kind of a surprise (or shock) to me. Is using extract(@sprite, 1); with a 1-based index as in the PR (#35) the way to go?

from node-sprite-generator.

selaux avatar selaux commented on September 4, 2024

Closed with #35.

from node-sprite-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.