GithubHelp home page GithubHelp logo

flatMap is missing about rambda HOT 5 CLOSED

selfrefactor avatar selfrefactor commented on May 22, 2024 1
flatMap is missing

from rambda.

Comments (5)

selfrefactor avatar selfrefactor commented on May 22, 2024 1

This is big IF for the change to Typescript as we are still waiting for varadic arguments support. That may happen this year maybe not. When it does, it may lead to rewrite but it could lead just to easier to read/write typings file.
So meanwhile feel free to open PR with any useful method that you think it is missing in Rambda.

from rambda.

selfrefactor avatar selfrefactor commented on May 22, 2024

Thanks for opening the issue and your suggestions.

While you explicitly describe your request, it will be much easier for me if you accompany each of them with simple pseudo-code, such as:

const result = R.foo({a: 1, b: '2'}, R.type) 
// result is `['Number', 'String']` 

In general I am open to implement all of your suggestions, but that will have to wait for Typescript 2.8 to arrive(between 1 and 2 months from now).

Then Rambda will switch to Typescript and all of method will be rewritten. During this major change, I will implement all of your suggestions.

I hope you do understand and I will wait for the pseudo-codes.

from rambda.

davidjbradshaw avatar davidjbradshaw commented on May 22, 2024

Why the switch to TypeScript? Surely that will just cut down on the pool of people who could help with the project.

I was just looking at switching to this from Ramda, with the view that I would just implement and contribute any methods that I currently use that are currently missing. If you switch to TypeScript then I think I will just have to fork the project which is a shame.

from rambda.

thejohnfreeman avatar thejohnfreeman commented on May 22, 2024

I can help you with some of these functions, but can you answer some questions first? I have read the CONTRIBUTING.md.

  1. It seems like you implement functions twice, in both lib and modules. You have a prepublish command to build lib from modules, but why do you commit it? Do you expect contributors to commit it as well?
  2. It seems like you haven't migrated to TypeScript yet. Is that right?
  3. You have dissoc but no assoc. Is there an assoc under a different name?

I need assoc and flatMap myself.

from rambda.

selfrefactor avatar selfrefactor commented on May 22, 2024

That is very nice of you to help me out.

Here are the answers:

  1. I commit it as it is needed for ES5 support. I don't expect the contributors to run the prepublish command.
  2. No. Still waiting for varadic support landing in Typescript microsoft/TypeScript#5453
  3. assoc landed because of someone did a PR. Feel free to add dissoc if you need it.

from rambda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.