PermissionError on Windows when using the 'load' action with uploaded files about django-smuggler

[jaap3]

I'm not sure, smuggler hasn't really been tested on windows as far as I known.

When you upload a fixture it is saved in a temporary directory and then it's loaded. For some reason on your system this file seems to be locked. Does this happen every time you try to load?

It's hard to reproduce/debug this issue without access to a Windows system, so a PR to demonstrate and fix this issue would be much appreciated.

(Currently travis only runs on linux so that'll have to change as well).

[semente]

Hey, @ManiMozaffar and @kenliit! I'm sorry you are having this issue on Windows. As @jaap3 noted, it is hard for us debug this issue because we don't run a Windows environment so could you share the whole traceback output?

It is not clear for me if the error happens on smuggler.utils.load_fixtures or on os.unlink() from https://github.com/semente/django-smuggler/blob/master/smuggler/views.py#L149.

[semente]

It is possible that it is missing a stream.close() at https://github.com/semente/django-smuggler/blob/master/smuggler/utils.py#L69.

[jaap3]

Temporary files are created here:

django-smuggler/smuggler/views.py

Line 113 in 524b99f

destination_path = tempfile.mkstemp(suffix=suffix, prefix=prefix + "_")[

They are written here:

django-smuggler/smuggler/utils.py

Line 19 in 524b99f

def save_uploaded_file_on_disk(uploaded_file, destination_path):

Removed here:

django-smuggler/smuggler/views.py

Line 152 in 524b99f

os.unlink(tmp_file)

I think the issues is related to the creation of the temporary files. mkstemp returns a tuple of two values a file pointer and a path (https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp), smuggler ignores the first one and always uses a path.

However, the file pointer is similar to an open file.

I found this Stack Overflow answer which probably contains the correct solution:

https://stackoverflow.com/questions/34716996/cant-remove-a-file-which-created-by-tempfile-mkstemp-on-windows

It would be greatly appreciated if someone with access to a Windows computer can test this fix and make a pull request.

[jaap3]

I created a pull request, but cannot test if this is actually the correct solution.

[semente]

good catch @jaap3!