GithubHelp home page GithubHelp logo

Comments (2)

underyx avatar underyx commented on July 30, 2024

I remember implementing it like that at first, and it didn't work 😞

I think the issue was that when targeting specific files, semgrep would just assume that it's the correct language for the given rules, and it would return tons of parse errors (since if an HTML file was changed, it'd get directly targeted, while the repo might configured for r/python). I used directory targeting and post-filtering files so that semgrep would stop scanning files of the wrong language.

Another issue I think I recall is that rule IDs were being rewritten with relative path fragments, but my memory is hazy and this one might have been a different problem.

from semgrep-action.

brendongo avatar brendongo commented on July 30, 2024

Once semgrep/semgrep#1507 is merged and released
can update https://github.com/returntocorp/semgrep-action/blob/develop/src/semgrep_agent/semgrep.py#L138 to send targets instead of includes. (Also need to update to use this cli flag)

from semgrep-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.