GithubHelp home page GithubHelp logo

Comments (4)

rpavlik avatar rpavlik commented on July 17, 2024

Would prefer to have that just come with the display info in the descriptor, since that's not rendermanager-specific - so an HDK could say, hey, here's an array of possible hardware IDs that I might have:

"hardwareIds": [
  [ "SEN", "1019"],
  [ "SVR", "1019"]
]

(Yes, I'd vote for including the product ID in string form as hex, and then parsing it with std::stringstream with a std::hex modifier - because nobody normally interacts with those in decimal. Some VR software uses the product id in decimal, but it's not pretty.)

from osvr-rendermanager.

russell-taylor avatar russell-taylor commented on July 17, 2024

If we're going to parse as hex, the values should be "0x1019" to avoid confusing the person making the files. Or they can be named with a name that has hex in it rather than just un-named string members.

We don't currently need the product ID for RenderManager's purposes, just the vendor ID.

Glad to have this issue moved to core if you prefer.

from osvr-rendermanager.

rpavlik avatar rpavlik commented on July 17, 2024

Sounds good to add the prefix. I think to avoid it getting unwieldly the tuple-style arrays are OK with the 0x in them. We'll need product ID for core, and presumably at some point for more fine-grained direct mode controls.

Yes, I'd like this to be core.

from osvr-rendermanager.

russell-taylor avatar russell-taylor commented on July 17, 2024

Handled in 74a2042

from osvr-rendermanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.