GithubHelp home page GithubHelp logo

Comments (10)

jakzal avatar jakzal commented on September 20, 2024

The interface was deprecated as I think it's better to have one way of doing things. However, I can see how the factory can be useful and I'll probably remove the deprecation as 2.0 wasn't released yet.

@spolischook is this the only case where you find the factory useful?

from behatpageobjectextension.

spolischook avatar spolischook commented on September 20, 2024

@jakzal this is the only way that we can interact with all pages in one context - it's perfect case because inject more then 100 pages in constructor is weird.

from behatpageobjectextension.

tikolakin avatar tikolakin commented on September 20, 2024

100 pages in constructor is weird.

Or context can be organized in a better way to avoid to many parameter.

from behatpageobjectextension.

spolischook avatar spolischook commented on September 20, 2024

@tikolakin It's ok if you have isolate your context in that layer.
Ok, let say that, the main disadvantage of DI way with injecting pages in context it's context by itself. I need to create context that can be extended by MinkContext even if it will be empty. Is it ok?

from behatpageobjectextension.

spolischook avatar spolischook commented on September 20, 2024

any suggestions?

from behatpageobjectextension.

jakzal avatar jakzal commented on September 20, 2024

@spolischook never extend the MinkContext. You can only do it once as otherwise you'll be duplicating step definitions (Behat won't let you). Use the RawMinkContext or MinkAwareContext.

from behatpageobjectextension.

jakzal avatar jakzal commented on September 20, 2024

I'll bring back the PageObjectAware before the stable release.

from behatpageobjectextension.

 avatar commented on September 20, 2024

Sorry to interrupt, but when exactly are you going to revert the deprecation?
The problem is that we also use your library but can not adopt it to its full extent because of PageObjectAware being deprecated.
Thanks in advance.

from behatpageobjectextension.

jakzal avatar jakzal commented on September 20, 2024

@old-town @spolischook I'd appreciate if you tested the latest dev-master with your apps. Cheers!

from behatpageobjectextension.

spolischook avatar spolischook commented on September 20, 2024

@jakzal we decide use own implementation of ElementFactory. But I still sure that factory is needed, I use it in elements for getting other elements

from behatpageobjectextension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.