Comments (10)
The interface was deprecated as I think it's better to have one way of doing things. However, I can see how the factory can be useful and I'll probably remove the deprecation as 2.0 wasn't released yet.
@spolischook is this the only case where you find the factory useful?
from behatpageobjectextension.
@jakzal this is the only way that we can interact with all pages in one context - it's perfect case because inject more then 100 pages in constructor is weird.
from behatpageobjectextension.
100 pages in constructor is weird.
Or context can be organized in a better way to avoid to many parameter.
from behatpageobjectextension.
@tikolakin It's ok if you have isolate your context in that layer.
Ok, let say that, the main disadvantage of DI way with injecting pages in context it's context by itself. I need to create context that can be extended by MinkContext even if it will be empty. Is it ok?
from behatpageobjectextension.
any suggestions?
from behatpageobjectextension.
@spolischook never extend the MinkContext. You can only do it once as otherwise you'll be duplicating step definitions (Behat won't let you). Use the RawMinkContext or MinkAwareContext.
from behatpageobjectextension.
I'll bring back the PageObjectAware before the stable release.
from behatpageobjectextension.
Sorry to interrupt, but when exactly are you going to revert the deprecation?
The problem is that we also use your library but can not adopt it to its full extent because of PageObjectAware being deprecated.
Thanks in advance.
from behatpageobjectextension.
@old-town @spolischook I'd appreciate if you tested the latest dev-master with your apps. Cheers!
from behatpageobjectextension.
@jakzal we decide use own implementation of ElementFactory. But I still sure that factory is needed, I use it in elements for getting other elements
from behatpageobjectextension.
Related Issues (20)
- verifyUrl() can report expected and found URL as the same HOT 1
- User Notice: Undefined property: Page\HomePage::$factory HOT 2
- What is best practice for using BPOE? HOT 5
- Fatal error: Call to a member function createPage() on null (Behat\Testwork\Call\Exception\FatalThrowableError) HOT 7
- Scenario works fine on pc but fails on Docker/Bitbucket HOT 3
- Expected to be on "xxx" but found "" instead HOT 6
- Misleading error when WebDriver fails to create a session
- Clicking link, when emulating device, does not work HOT 1
- Have Page subclasses to hold site-wide element locators and methods HOT 4
- ERROR 500 HOT 3
- fatal-error-uncaught-argument count error HOT 5
- Outdated Documentation HOT 2
- Support PHP 8.0 HOT 12
- Trying to get in touch regarding a security issue HOT 3
- Cannot autowire service ... "$factory" of method "SensioLabs\Behat\PageObjectExtension\PageObject\Page::__construct()" references interface "Sensi oLabs\Behat\PageObjectExtension\PageObject\Factory" HOT 1
- getDriver method is not available in Page class HOT 13
- Remove verify() from $page->open() function HOT 2
- Ability to reuse code among page/element objects HOT 2
- Remove path and selector from page and element HOT 2
- Fatal error: Call to a member function open() on null HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from behatpageobjectextension.