Comments (11)
@sentriz, thanks for pointing out the path
not getting set bug. I fixed it and did a code audit to make sure that path
was set every time a Dirent
is created.
Please give https://github.com/karrick/godirwalk/releases/tag/v1.15.2 a try.
from gonic.
Just finished scanning my library and all seems to be well: symlinks work as expected, and there are no panics.
from gonic.
should be fixed now. try v0.6.1
can reopen if somethings gone wrong. thanks!
from gonic.
Thank you very much for adding this.
The symlinks seem to work fine, however at the moment I am getting:
panic: runtime error: invalid memory address or nil pointer dereference
I am not sure if it is because of a folder, or a tag read error (those can cause a similar panic).
from gonic.
hmm. could you post the full traceback with the panic please?
from gonic.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x88 pc=0x377a0c]
goroutine 70 [running]:
senan.xyz/g/gonic/scanner.(*Scanner).callbackPost(0x1995a10, 0x19715c0, 0xb, 0x18ee2d0, 0x0, 0x0)
/home/alarm/git/gonic/scanner/scanner.go:232 +0x70
github.com/karrick/godirwalk.walk(0x19715c0, 0xb, 0x18ee2d0, 0x1be1f88, 0xb, 0x0)
/home/alarm/go/pkg/mod/github.com/karrick/[email protected]/walk.go:308 +0x30c
github.com/karrick/godirwalk.walk(0x19b8fa7, 0x5, 0x1a13fe0, 0x1be1f88, 0x0, 0x0)
/home/alarm/go/pkg/mod/github.com/karrick/[email protected]/walk.go:280 +0x258
github.com/karrick/godirwalk.Walk(0x19b8fa7, 0x5, 0x1830788, 0x12, 0x9c14a0)
/home/alarm/go/pkg/mod/github.com/karrick/[email protected]/walk.go:220 +0x13c
senan.xyz/g/gonic/scanner.(*Scanner).Start(0x1995a10, 0x0, 0x0)
/home/alarm/git/gonic/scanner/scanner.go:88 +0x1c4
senan.xyz/g/gonic/server/ctrladmin.(*Controller).ServeStartScanDo.func1.1(0x19abc00)
/home/alarm/git/gonic/server/ctrladmin/handlers.go:265 +0x28
created by senan.xyz/g/gonic/server/ctrladmin.(*Controller).ServeStartScanDo.func1
/home/alarm/git/gonic/server/ctrladmin/handlers.go:264 +0x2c
from gonic.
hi!
I can reproduce this. while scanning I keep track of the tree using a stack, pushing for dirs, and popping when we leave them. symlinks to dirs aren't being pushed currently, so the nil pointer happens when the pop happens but nothing there.
i've asked a quesstion about this here
from gonic.
from gonic.
The following tag has the feature request, however I have been testing a performance improvement branch, and am about ready to release that, but wanted to get this feature out for you first.
https://github.com/karrick/godirwalk/releases/tag/v1.15.1
from gonic.
thank you for that karrick. comment left here:
karrick/godirwalk#45 (comment)
not sure if you get notified for closed PRs
from gonic.
@Flameborn could you try gonic v0.6.2
if you have a chance?
from gonic.
Related Issues (20)
- symbol lookup error HOT 7
- query optimisations for massive libraries HOT 29
- Extremely high memory usage when running an incremental scan on 200k+ files HOT 5
- Can't play Web Radio in Jukebox mode: error creating playlist items: find track by id: not found HOT 4
- feat: stream timeOffset when not trancoding HOT 8
- Libraries without folder album art won't get any cover art HOT 1
- DSub can't play song when bitrate is set to "unlimited" HOT 4
- DTS audio files cannot be played HOT 1
- Error 10 when retrieving bookmarks HOT 1
- Mixed case file extension (Mp3) not being picked up in scan HOT 1
- Unable to delete transcoding profiles containing "http://" HOT 1
- Gonic crashes when Maloja is set as listenbrainz scrobble server HOT 13
- Jukebox not working correctly HOT 18
- Option to selectively scan music library HOT 4
- [feature request] export playlists to m3u HOT 2
- Config setting to limit cache size
- Better documentation of GONIC_EXCLUDE_PATTERN HOT 1
- Allow setting user for docker image HOT 4
- Request: Parse `format` param in `stream` request for per-request transcoding HOT 3
- LastModified field is set to 0?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gonic.