args.env turned into array if set multiple times, causing command to fail about cli

[sdepold]

If I understand you correctly, you have the following or a similar config/config.json file:

{
  "development": {
    "dialect": "sqlite",
    "storage": "./db.development.sqlite",
    "env": "development"
  },
  "test": {
    "dialect": "sqlite",
    "storage": "./db.test.sqlite",
    "logging": false
  },
  "production": {
    "username": "root",
    "password": null,
    "database": "database_production",
    "host": "127.0.0.1",
    "dialect": "mysql"
  }
}

And you run a command like this:

sequelize --env=development db:migrate

And you receive an error then? My output looks like this:

Sequelize [Node: 0.10.32, CLI: 0.3.1, ORM: 2.0.0-dev13, sqlite3: ^2.2.7]

Loaded configuration file 'config/config.json'.
Using environment 'development'.
[21:41:08] Using sequelizefile ~/Projects/sequelize/cli/lib/sequelizefile.js
[21:41:08] Starting 'db:migrate'...
[21:41:08] Finished 'db:migrate' after 50 ms
Running migrations...
20141003210006-create-omnom.js
Completed in 12ms

Can you ensure that the issue still exists?

[rayshan]

Sorry it was indeed unclear. I actually meant to say .sequelizerc. My config.json looks like yours. My .sequelizerc looks like:

module.exports = {
  "env": 'development',
  "coffee": true,
  "config": "./db/config.json",
  "migrationsPath": "./db/migrations",
  "modelsPath": ".lib/models"
};

Then if I run sequelize --env=development db:migrate, args.env turns into an array, and this error is thrown:

'db:migrate' errored after 17 ms The dialect mysql is not supported. (Error: Please install mysql package manually)

Even though I'm using Postgres. I'm now on the latest 0.3.3.

[tylerFowler]

+1 I'm actually still seeing this in the 1.7.0 CLI.

[paulxtiseo]

+1, I think. I have the same or similar issue.

When I run sequelize db:migrate --migrations-path 'migrations/postgres' --config 'postgres/config.json', resolve() throws an error in getConfigFile().

Starting 'db:migrate'...
    at Object.posix.resolve (path.js:439:13)
    at Object.module.exports.getConfigFile (/usr/local/lib/node_modules/sequelize-cli/lib/helpers/config-helper.js:13:19)
    at Object.module.exports.configFileExists (/usr/local/lib/node_modules/sequelize-cli/lib/helpers/config-helper.js:24:31)
    at getMigrator (/usr/local/lib/node_modules/sequelize-cli/lib/tasks/db.js:211:22)

My .sequelizerc is set as:

var path = require('path')
module.exports = {
  'config': path.resolve('migrations', 'config.json'),
}

Looking at args.config in getConfigFile when I run the CLI line with --config, it seems to be an array:

[ 'migrations/postgres/config.json',
  '/Users/ptiseo/Documents/Repositories/Mailroom/migrations/config.json' ]

If I remove .sequelizerc, the sequelize db:migrate --migrations-path 'migrations/postgres' --config 'migrations/postgres/config.json' works.

This is with CLI v1.8.3.

[sdepold]

alright. let's fix this

[sdepold]

boom landed in master. I will wait for another PR till I release a new patch version

[sdepold]

and it's live as 1.9.1

[rayshan]

Thanks!