GithubHelp home page GithubHelp logo

Comments (3)

dtolnay avatar dtolnay commented on September 14, 2024 1

default-features = false is supported.

from bytes.

dtolnay avatar dtolnay commented on September 14, 2024

I would prefer to leave it. All the cfg features we use are additive, so if the crate compiles successfully with various feature combinations and passes tests with all features enabled then it's fine. Introducing cfg gunk into the test suite would make it less likely to cover what we want.

from bytes.

kentfredric avatar kentfredric commented on September 14, 2024

That sounds reasonable. Just a follow up though, is it fair to say that this means "default-features = false" is inherently unsupported? ( Or perhaps, unsupported unless your crate intends to also demand futures specifically selected by their consumers ).

If so, it may pay to put a cfg! bomb in there so it won't build without one of a minimal set.

( Otherwise, the existence of this bug will serve its own purpose if anyone else goes looking )

from bytes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.