Comments (3)
default-features = false is supported.
from bytes.
I would prefer to leave it. All the cfg features we use are additive, so if the crate compiles successfully with various feature combinations and passes tests with all features enabled then it's fine. Introducing cfg gunk into the test suite would make it less likely to cover what we want.
from bytes.
That sounds reasonable. Just a follow up though, is it fair to say that this means "default-features = false" is inherently unsupported? ( Or perhaps, unsupported unless your crate intends to also demand futures specifically selected by their consumers ).
If so, it may pay to put a cfg!
bomb in there so it won't build without one of a minimal set.
( Otherwise, the existence of this bug will serve its own purpose if anyone else goes looking )
from bytes.
Related Issues (20)
- Implement ToOwned on Bytes HOT 13
- Update bincode dev-dependency to 1 HOT 1
- Implement support for SmallVec<u8; N>? HOT 2
- Working with more complex types is difficult HOT 1
- Removing From<Vec<u8>> and From<ByteBuf> was mistake HOT 1
- Allow `Cow<'a, [u8]>` to be deserialized even when visitor receives owned bytes. HOT 3
- Implement (de-)serializing for `[u8; N]` HOT 2
- How to handle Vec<Vec<u8>> HOT 1
- Functionality of #[serde(with = "serde_bytes")] for deserialization of &[u8] HOT 7
- How to use this crate without use of struct fields
- Support for human-readable formats? HOT 5
- Is there a way to borrow when serialize and own when deserialize? HOT 1
- `#[serde(with = "serde_bytes")]` does not work in no_std. HOT 1
- Consider sealing serde_bytes::Serialize and Deserialize traits
- Support for Arc HOT 2
- support byte array of any size. HOT 1
- `Vec<Vec<u8>>` conversion support missing HOT 1
- Consider not using specialization even after it lands HOT 2
- Cannot deserialise into &[u8] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bytes.