GithubHelp home page GithubHelp logo

Comments (2)

SergioBenitez avatar SergioBenitez commented on May 14, 2024 8

cookie now uses RustCrypto for pure-Rust based cryptography, ideally resolving this issue.

from cookie-rs.

justinturpin avatar justinturpin commented on May 14, 2024

So cookie-rs really only needs the HMAC portion of Ring, which mostly involves hashing and then a constant-time comparison (see https://briansmith.org/rustdoc/src/ring/hmac.rs.html#390). Python's own constant time string comparison function can be found here: https://github.com/python/cpython/blob/d0d3e99120b19a4b800f0f381b2807c93aeecf0e/Modules/_operator.c#L727 . Could such a function be safely written in rust in this library? I see one attempt here https://github.com/cesarb/constant_time_eq/blob/master/src/lib.rs#L4 but I wonder how you would rigorously test that in practice it is actually constant time.

Additionally here is Golangs implementation, which unless I'm missing something, is pure Go and looks pretty straighforward: https://golang.org/src/crypto/subtle/constant_time.go

Update: I just realized that cookie also provides the ability to encrypt the cookies, which none of this would cover and would still need a solution.

from cookie-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.