Comments (4)
The solution here is to actually find the original cookie in the Jar and store that in the removed_cookies list instead of just storing the cookie name. This would have the side-effect of fixing what I consider to be another bug, which is that empty_jar.remove("foo")
produces a Set-Cookie header even though there was no original cookie by that name.
from cookie-rs.
The browser does not pass along any other information besides the name and value of the cookie. As a result, unless cookie
is storing cookies, proper deletion is simply impossible with the current API. I believe that the delete
method should instead take in a Cookie
and specify that it should have all of the original fields set. We can then set the max_age
and expires
fields properly.
from cookie-rs.
Oh crud, you're right. Or, if we're happy with the current behavior of Max-Age and Expires when removing, we could just have remove()
take two more optional parameters for path and domain, e.g.
fn remove<N, P, D>(&self, cookie_name: N, path: Option<P>, domain: Option<D>)
where N: Into<Cow<'static, str>>,
P: Into<Cow<'static, str>>,
D: Into<Cow<'static, str>>
from cookie-rs.
Yeah, we could do that as well.
I'll be revamping CookieJar
in the near future, and I'll make sure to fix this along the way.
from cookie-rs.
Related Issues (20)
- SameSite::None for unknown values? HOT 4
- Support optional weekday date format for Expires HOT 2
- v0.15.1 missing on crates.io HOT 4
- Nightly detection does not take into account whether features can actually be used HOT 9
- Panic when verifying malformed signed cookie HOT 2
- Parse multiple cookies in single string? HOT 1
- 0.16 release HOT 3
- Replace base64 with base64ct HOT 5
- Iterator over all cookies from string HOT 1
- Removing cookies by name HOT 4
- Private, signed & key methods missing
- Why was ring removed? HOT 1
- Commas are not encoded correctly
- Cookie builder doesn't ignore leading dots (as the `FromStr` implementation does) HOT 4
- Use `std::time::Duration` instead of `time::duration::Duration` for `max-age` HOT 1
- Trait bound error after upgrading to 0.17.0 HOT 1
- Support for `__Host-` cookies HOT 4
- Set Removal Cookies SameSite to Lax HOT 3
- Question : SignedJar::verify_result HOT 2
- aes-gcm vulnerability HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cookie-rs.