GithubHelp home page GithubHelp logo

Comments (8)

Skaanning avatar Skaanning commented on June 12, 2024

bindingRedirect of Elasticsearch.net from older versions to 5.0 seems to work just fine.
So i guess this is not really an issue.

from serilog-sinks-elasticsearch.

ffMathy avatar ffMathy commented on June 12, 2024

It would still make sense to update the support, especially for projects that rely on other COM projects. The problem is that assembly binding redirects don't work for COM.

from serilog-sinks-elasticsearch.

mivano avatar mivano commented on June 12, 2024

The current implementation does work against a v5 of ES as it uses pretty basic API calls. It makes sense to upgrade to the latest elasticsearch client too. Care for a PR?

from serilog-sinks-elasticsearch.

ffMathy avatar ffMathy commented on June 12, 2024

I tried, but the project uses the old project.json format and I don't know how to convert away from that.

It is not used anymore and it makes my Visual Studio confused.

from serilog-sinks-elasticsearch.

ffMathy avatar ffMathy commented on June 12, 2024

@mivano could you look at switching to .csproj? Then I can work on this task, and so can many other people who use VS2017.

from serilog-sinks-elasticsearch.

mivano avatar mivano commented on June 12, 2024

I have no objection switching to the new format. Unfortunately I do not have the time available.

from serilog-sinks-elasticsearch.

ffMathy avatar ffMathy commented on June 12, 2024

Finally got time to do both the format stuff and the NuGet stuff in #109. Could you take a look?

from serilog-sinks-elasticsearch.

mivano avatar mivano commented on June 12, 2024

All merged to master. Thanks!

from serilog-sinks-elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.