component: netlify-site keys issue about components

[DavidWells]

Good question. Components tear down everything they create, including this deploy key. So if they share a dependency (this key) that would be a problem and/or require additional lookups whenever other netlify components are deployed

…

On May 10, 2018, at 9:59 AM, Enric Bisbe Gil ***@***.***> wrote: I'm not sure that it's the desired behaviour but each time the netlify-site components is deployed generates a new key in the github account. I assume that you would reuse the first one created. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[ebisbe]

But they keep some type of track of the state of that component? If no changes are made then when executin deploy it should not do anything right?

[DavidWells]

I might have misunderstood here.

You are saying each time you run deploy with no changes to anything, more and more keys are created?

Can you share your redacted serverless.yml file?

[ebisbe]

Yes I'm saying that. I have now 10 emails with this subject

[GitHub] A new public key was added to ebisbe/netlify-landing-page

My yml file is:

type: landing-page
version: 0.0.1

components:
  landingPageFunction:
    type: aws-lambda
    inputs:
      memory: 512
      timeout: 10
      handler: code/handler.landingPageFunction
      env:
        MAILCHIMP_API_KEY: c2f2208321587c71381d20d4a1deae4e-us18
        MAILCHIMP_LIST_ID: 36d813410c
        MAILCHIMP_REGION: us18
  apiEndpoint:
    type: rest-api
    inputs:
      gateway: aws-apigateway
      routes:
        /sign-up:
          post:
            function: ${landingPageFunction}
            cors: true
  myNetlifySite:
    type: netlify-site
    inputs:
      netlifyApiToken: adsfasdf
      githubApiToken: adfasf
      siteName: nricu-landing.netlify.com
      siteDomain: nricu-landing.netlify.com
      siteRepo: https://github.com/ebisbe/netlify-landing-page
      siteBuildCommand: npm run build
      siteBuildDirectory: build
      siteRepoBranch: master
      siteForceSSL: true
      siteRepoAllowedBranches:
          - master
      siteEnvironmentVariables:
        REACT_APP_SIGNUP_API: ${apiEndpoint.url}sign-up

Right now it's not generating the site in netlify... Not sure why neither.

[DavidWells]

Looks like site env vars property is incorrect https://github.com/serverless/components/blob/master/examples/netlify-site-example/serverless.yml

Should be siteEnvVars.

I don't know if that's related to this issue though.

Will need to look into it when I'm back next week

[ebisbe]

Yes I know that it's bad formed but yesterday I saw it somewhere and it worked. Today I cannot find where I saw it and seems it never existed that siteEnvironmentVariables. That was not the real problem.
I've been fighting to deploy a new app and finally found that somehow the state.json does not track properly the state because when I redeploy I see that message:

⌈  ➜   ~/Development/decoralyte/netlify-site
⌊☻ components deploy
Updating Lambda: mailChimpCall
Deploying netlify site:
Creating netlify deploy key
Adding netlify deploy key to github repo
{ name: 'nricu-landing.netlify.com',
  repo:
   { deploy_key_id: '5af5dd19b13fb17a46b6051b',
     provider: 'github',
     public_repo: false,
     repo_branch: 'master',
     repo_path: 'ebisbe/netlify-landing-page',
     repo_type: 'git',
     repo_url: 'https://github.com/ebisbe/netlify-landing-page',
     allowed_branches: [ 'master' ],
     cmd: 'npm run build',
     dir: 'build',
     env:
      { REACT_APP_SIGNUP_API: 'https://5mg9655v2i.execute-api.us-east-1.amazonaws.com/dev/sign-up' } } }
Creating netlify site
{ errors: { subdomain: [ 'must be unique' ] } }
Creating github webhook
Creating netlify webhook deploy_created
Creating netlify webhook deploy_failed
Creating netlify webhook deploy_failed
netlify-site: ✓ Created Netlify Site
REST API resources:
  POST - https://5mg9655v2i.execute-api.us-east-1.amazonaws.com/dev/sign-up

That means it's trying again to deploy a new site. But before that I could not deploy due to custom_domain conflicts in Netlify ( I assume ), the issue:

{ errors:
   { custom_domain:
      [ 'conflicts with an SSL certificate installed by another user' ] } }

And my solution was to comment the line that sets up a custom domain.

[ebisbe]

I've just tried to update siteBuildDirectory and it's not updated on netlify.

[eahefnawy]

closing this as we've made a complete rewrite of the core and this issue no longer exists.