No forceInclude equivalent in the new build.esbuild configuration about serverless

[garethmcc]

Thanks @kdybicz . One thing to mention is that 4.1.5 went out with some changes that may or may not have helped with this. If possible, could you confirm while we look into this.

To upgrade to 4.1.5 just run serverless command such as serverless --version and it will auto upgrade

[kdybicz]

Hey @garethmcc! I'm afraid I don't see anything useful in the Changelog. I've tried again with include and forceInclude in the build.esbuild for the sls 4.1.5, but it gave me the same error message:

✖ Build failed with 1 error:
/Users/kamil/.serverless/releases/4.1.5/package/node_modules/esbuild/lib/main.js:253:12: ERROR: Invalid option in build() call: "forceInclude"
ServerlessError2: Build failed with 1 error:
/Users/kamil/.serverless/releases/4.1.5/package/node_modules/esbuild/lib/main.js:253:12: ERROR: Invalid option in build() call: "forceInclude"
    at Esbuild._build (file:///Users/kamil/.serverless/releases/4.1.5/package/dist/sf-core.js:1026:11533)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async before:package:createDeploymentArtifacts (file:///Users/kamil/.serverless/releases/4.1.5/package/dist/sf-core.js:1026:4371)

[Mmarzex]

Hi @kdybicz , it sounds like what you are looking for is the external property. Any npm modules you set there are not included and instead will be put in a node_modules folder in the resulting zip file that gets uploaded to AWS.

[kdybicz]

@Mmarzex well, I guess I would like this module to be included instead :)

[Mmarzex]

@kdybicz Included in what? If you want it included in the deployment package but not bundled you would use external, which I believe is what you are asking for here from my understanding of forceInclude.

[kdybicz]

To make it clear, as the @keyv/redis is more referenced in code directly, but is required for the code to work I needed to use:

custom:
  webpack:
    includeModules:
      forceInclude:
        - '@keyv/redis'

to be bundled at all: apollographql/apollo-server#6682 (comment)

I will test the external later Today and let you know if that has solved my issue.

[kdybicz]

@Mmarzex looks like external did the trick, though I must say that this behavior wasn't clear at all when looking at the documentation:

    # NPM packages to not be bundled
    external:
      - @aws-sdk/client-s3

I appreciate your help!