GithubHelp home page GithubHelp logo

Comments (2)

mbrubeck avatar mbrubeck commented on September 18, 2024

I'm open to this idea. I would love it if the function could take a slice instead of an array + length, but I don't know whether that will be possible.

Unfortunately, panic! in const contexts was only stabilized in Rust 1.57, which as far as I am aware would cause an issue since currently the const_new feature only requires Rust 1.51.

We could put the new function behind its own feature gate that requires Rust 1.57.

Also note that, as soon as I have time, I will be switching the main development branch to #284 which will be the basis for smallvec 2.0, which gives us a chance to increase the minimum Rust version and make other breaking changes.

from rust-smallvec.

jakergrossman avatar jakergrossman commented on September 18, 2024

I would love it if the function could take a slice instead of an array + length

I'm not sure how you could specify the logical capacity passing just a slice, though. Maybe I'm missing something.

Edit: Hm I guess you would do something like:

impl<T, const N: usize> SmallVec<[T; N]> {

    // ...

    pub const fn from_const_slice(items: &[T]) -> Self {
        if items.len() >= N {
            panic!("Expected length of slice to be less than or equal to array size");
        }

        SmallVec {
            // ... something here
        }
    }

    // ...

}

I guess I'm not sure how we can constly move a smaller size slice into a bigger array, since we want to move the contiguous slice into the SmallVec.

from rust-smallvec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.