sfc-gh-eraigosa / atom-git-review

Need a way to work with gerrit in atom. This is a plugin for using git-review on atom.

Hi there 👋 I'm Edward

• 🔭 I’m currently working on ❄️ releases!
• 🌱 I’m currently working in Go, Java, bash and Python
• 👯 Intrested in new OSS projects, if you have one plz drop me a linkedIn DM/invite
• 😄 Pronouns: Him/He
• 📘 Find out more about me on LinkedIn
• 📖 Ask me about CI / CD

atom-git-review's Issues

Installing with pip

Hi Edward,

I installed your plugin using apm, but the Git Review commands do not show up in Atom's Command Palette, even after restart. I guessed it's because I missed the pip install. So, I ran pip install git-review, but it still did not work. What am I missing?

Thanks in advance!

Uncompatible package with Atom >= 1.0

When trying to install with apm install git-review :

No available version compatible with the installed Atom version: 1.0.19

Is it possible to make this package compatible with Atom >= 1.0 ? It'd be great !

Thanks

Failed to load the git-review package

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.199.0 ⚠️ in 1.0 API Preview Mode ⚠️
System: Mac OS X 10.10.4
Thrown From: git-review package, v0.2.1

Stack Trace

Failed to load the git-review package

At Cannot read property 'prototype' of undefined

TypeError: Cannot read property 'prototype' of undefined
  at __extends (/Users/spaquet/.atom/packages/git-review/lib/views/status-view.coffee:4:199)
  at /Users/spaquet/.atom/packages/git-review/lib/views/status-view.coffee:19:5
  at Object.<anonymous> (/Users/spaquet/.atom/packages/git-review/lib/views/status-view.coffee:52:5)
  at Object.<anonymous> (/Users/spaquet/.atom/packages/git-review/lib/views/status-view.coffee:14:1)
  at Module._compile (module.js:452:26)
  at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Object.<anonymous> (/Users/spaquet/.atom/packages/git-review/lib/review.coffee:16:14)
  at Object.<anonymous> (/Users/spaquet/.atom/packages/git-review/lib/review.coffee:15:1)
  at Module._compile (module.js:452:26)
  at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Object.<anonymous> (/Users/spaquet/.atom/packages/git-review/lib/git-review.coffee:16:10)
  at Object.<anonymous> (/Users/spaquet/.atom/packages/git-review/lib/git-review.coffee:15:1)
  at Module._compile (module.js:452:26)
  at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:707:34)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:186:28
  at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
  at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:177:12)
  at PackageManager.module.exports.PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:355:14)
  at PackageManager.module.exports.PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:325:14)
  at Atom.module.exports.Atom.startEditorWindow (/Applications/Atom.app/Contents/Resources/app.asar/src/atom.js:633:21)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:12:8)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:23:4)
  at Module._compile (module.js:452:26)
  at Object.loadFile [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/babel.js:162:21)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at setupWindow (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:91:23)
  at window.onload (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:32:7)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "language-erlang",
      "language-elixir",
      "language-objective-c",
      "language-prolog",
      "language-sass",
      "archive-view",
      "background-tips",
      "coffee-lint",
      "feedback",
      "emmet",
      "image-view",
      "open-on-github",
      "autocomplete-plus",
      "autocomplete-snippets",
      "autocomplete-paths",
      "language-latex",
      "language-mustache",
      "language-x86",
      "language-go",
      "language-java",
      "language-make",
      "language-perl",
      "language-php",
      "language-toml"
    ],
    "themes": [
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
.bin, vundefined
Sublime-Style-Column-Selection, v1.2.3
angularjs, v0.1.0
atom-prettify, v0.1.0
atom-rails, v0.4.0
auto-update-packages, v0.2.2
git-review, v0.2.1
go-to-view, v0.1.2
language-blade, v0.14.0
minimap, v4.9.0
minimap-find-and-replace, v4.2.0
node-debugger, v0.2.3
node-resolver, v1.0.1
pretty-json, v0.3.3
rails-navigation, v0.1.1
rails-rspec, v0.3.1
rsense, v0.6.0
ruby-block, v0.3.3
ruby-define-method, v0.2.0

# Dev
No dev packages