GithubHelp home page GithubHelp logo

Comments (6)

Ognian avatar Ognian commented on July 4, 2024 1

Added Ognian@e562ca5 but it is not tested yet... (don't have empty sd and/or usb ssd's now)

from picl-k3os-image-generator.

sgielen avatar sgielen commented on July 4, 2024

I think programmatically finding out the name of the first partition should be feasible. I guess the name of the disk is quite unpredictable and can also change in the future, so I would prefer not to hardcode any expectations of it. In that sense, I'd also like to get rid of this hardcoding of the expected name of the first partition that we have now.

Tools like lsblk are able to find out a partition tree from a block device, perhaps using /sys or /proc, I think it would be a good idea to find out how they do it, and use similar behaviour here.

from picl-k3os-image-generator.

Ognian avatar Ognian commented on July 4, 2024

Changed to Ognian@23ede0c should work but is still not tested...

from picl-k3os-image-generator.

cwoolum avatar cwoolum commented on July 4, 2024

I was able to test this. The first commit does work. The second one has the following error:

lsblk: error while loading shared libraries: libmount.so.1: cannot open shared object file: No such file or directory
mount: can't read '/etc/fstab': No such file or directory

from picl-k3os-image-generator.

cwoolum avatar cwoolum commented on July 4, 2024

I tried flashing a regular SD Card again afterward and failed due to the regex not matching. Since we're using sh instead of bash, the syntax needs to be a bit different.

if echo "$ROOTDISK" | grep -Eq $MMCROOT_REGEX; then

from picl-k3os-image-generator.

sgielen avatar sgielen commented on July 4, 2024

Just pushed as b3ed5f1, thank you @Ognian and @cwoolum :-)

from picl-k3os-image-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.