"Invalid regular expression" error when thousandSeparator is empty string about bootstrap-input-spinner

[villu164]

https://github.com/shaack/bootstrap-input-spinner/pull/62/files
ran into same issue, created fix

[Roman-]

An easy fix can be to replace this line
var thousandSeparator = numberFormat.format(1111).replace(/1/g, '')
with this
var thousandSeparator = numberFormat.format(1111).replace(/1/g, '') | ' '

[shaack]

Hi, thanks for reporting. Okay, I switched the locale to russian, but get no error. Which Browser and OS? In Chrome, it seems to work.

[Roman-]

Okay, looking deeper, after line 246 I've added this to debug:
console.log(locale, numberFormat.format(1111));
and it gave me this: es-AU 1111
My Chrome version: Version 78.0.3904.97 (Official Build) (64-bit)

[Roman-]

Yep, I've forgotten that I've decided to learn Spanish language and have added Spanish (apparently in Google settings) to the list of languages.
One way or another, this regex construction '\\' + thousandSeparator assumes that thousandSeparator has to be strictly one character long string (not always true) that has to be escaped in regex (also may not be true). This is a dangerous assumption which may cease to work in some cases, like with the es-AU locale here.
One more notice is that my OS is Ubuntu 16.04 LTS.

[shaack]

You are right. Looks like the localization feature needs to be reworked. Do you have an idea how to fix it? I can think about it next week, this week I have to much customer stuff to do.

[shaack]

I found some ideas here: https://stackoverflow.com/questions/11665884/how-can-i-parse-a-string-with-a-comma-thousand-separator-to-a-number

[villu164]

@shaack, any progress?

[czachor]

Same here with Polish locale.

Firefox reports an error in the console when I'm trying to insert input's value manually:

SyntaxError: \ at end of pattern 3 plugins.js:274:14
parseLocaleNumber https://localhost/foobar/js/plugins.20161010.js:269
inputSpinner https://localhost/foobar/js/plugins.20161010.js:122
jQuery 5
dispatch
handle
trigger
simulate
i

In Chrome:

Uncaught SyntaxError: Invalid regular expression: //: \ at end of pattern
at new RegExp ()
at parseLocaleNumber
at HTMLInputElement.
at HTMLInputElement.dispatch (jquery-3.5.1.min.js:2)
at HTMLInputElement.v.handle (jquery-3.5.1.min.js:2)

[shaack]

Fixed with 1e3de85