GithubHelp home page GithubHelp logo

Comments (5)

csyonghe avatar csyonghe commented on June 27, 2024 1

I think your workaround makes sense by treating null as empty string. Can you open a PR from your branch?

from slang.

jsmall-zzz avatar jsmall-zzz commented on June 27, 2024

I think this would probably better to just return UnownedStringSlice() rather than UnownedStringSlice("", 0).
There is a somewhat subtle distinction between UnownedStringSlice("") and UnownedStringSlice() - in that both are in effect empty strings, but it provides a way to differentiate a zero length string and an invalid/null string.

from slang.

csyonghe avatar csyonghe commented on June 27, 2024

If you are using the release build, that SLANG_ASSERT shouldn't exist to crash slangd. If it does, then it is something up in the callstack that can't handle an empty UnowendStringSlice, which is more worrying.

from slang.

theHamsta avatar theHamsta commented on June 27, 2024

If you are using the release build, that SLANG_ASSERT shouldn't exist to crash slangd. If it does, then it is something up in the callstack that can't handle an empty UnowendStringSlice, which is more worrying.

I remember that the release build crashed with new throwing an out of memory error. I could only used debug mode to investigate the issue.

from slang.

csyonghe avatar csyonghe commented on June 27, 2024

I see. So the real issue is still something different.

from slang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.