GithubHelp home page GithubHelp logo

Comments (11)

Ipotrick avatar Ipotrick commented on August 22, 2024 1
[[vk::binding(0,0)]] RWTexture2D<uint64_t> tex[];

[shader("compute")]
[numthreads(1, 1, 1)]
void main()
{
    imageAtomicAdd(tex[0], int2(0,0), uint64_t(0));
}

This is a repro for the crash.
It does not happen when the images are not in an array.
This does not cause a crash:

[[vk::binding(0,0)]] RWTexture2D<uint64_t> tex;

[shader("compute")]
[numthreads(1, 1, 1)]
void main()
{
    imageAtomicAdd(tex, int2(0,0), uint64_t(0));
}

from slang.

csyonghe avatar csyonghe commented on August 22, 2024 1

import glsl; is another (preferred) way to use glsl flavored intrinsics. But we should look into the crash.

from slang.

ArielG-NV avatar ArielG-NV commented on August 22, 2024

InterlockedAdd for 64bit types with images looks to only have a hlsl implementation:

[ForceInline]
void InterlockedAdd(__ref  int64_t dest,  int64_t value)
{
    __target_switch
    {
    case hlsl: __intrinsic_asm "InterlockedAdd";
    }
}

For now the glsl syntax variant of the operation should work as a workaround if only a spir-v/glsl target is needed: imageAtomicAdd

from slang.

Ipotrick avatar Ipotrick commented on August 22, 2024

How would i use imageAtomicAdd in the example code i have above? I dont understand.

from slang.

ArielG-NV avatar ArielG-NV commented on August 22, 2024

I believe the following should work: imageAtomicAdd(tex, ivec2(0,0), uint64_t(0));

from slang.

Ipotrick avatar Ipotrick commented on August 22, 2024

slang does not recognize imageAromicAdd nor ivec2. Do i need to import a specific module for this to work?

from slang.

ArielG-NV avatar ArielG-NV commented on August 22, 2024

the compiler flag -allow-glsl should enable GLSL syntax to work along-side HLSL syntax

from slang.

Ipotrick avatar Ipotrick commented on August 22, 2024

slang crashes when i try to use glsl syntax 😨

from slang.

ArielG-NV avatar ArielG-NV commented on August 22, 2024

That is not the expected result.

from slang.

ArielG-NV avatar ArielG-NV commented on August 22, 2024

This probably should be broken into 2 issues:
1 for the crash
1 for merging glsl.meta<->hlsl.meta image atomic operations

from slang.

Ipotrick avatar Ipotrick commented on August 22, 2024

I ll make another issue for the crash

from slang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.