GithubHelp home page GithubHelp logo

Comments (5)

tangent-vector-personal avatar tangent-vector-personal commented on June 22, 2024

This has some overlap with #38.

I'd like to make this a warning (two parameters with different names and overlapping bindings), with an option to make it trigger an error. This hasn't bubbled up to the top of the priority list yet.

As far as I understand, this is valid GLSL. It is okay to define overlapping bindings, so long as a given compiler shader ("version") only uses one or the other (I don't know if that is a static constraint or a dynamic one).

from slang.

nbentyNV avatar nbentyNV commented on June 22, 2024

Is it valid even if the declarations are in the same shader?
Issue #96 both the constant-buffer and sampler are bound to the same location and are being used in the shader, I don't see why this is valid.

I'm not suggesting Slang is doing anything wrong. Either glslang has a bug or GLSL has a bug.

from slang.

tangent-vector-personal avatar tangent-vector-personal commented on June 22, 2024

Do we get errors reported from the driver?

I would need to comb the spec carefully to know what is or isn't valid.

from slang.

tangent-vector avatar tangent-vector commented on June 22, 2024

I implemented a basic version of this in #118. I'll close this if/when I get confirmation that it seems to meet requirements (and doesn't give false positives).

from slang.

tangent-vector avatar tangent-vector commented on June 22, 2024

I've seen this trigger now in cases where it should, and nobody has reported false positives (yet), so I'm going to consider this good.

from slang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.