Comments (5)
This has some overlap with #38.
I'd like to make this a warning (two parameters with different names and overlapping bindings), with an option to make it trigger an error. This hasn't bubbled up to the top of the priority list yet.
As far as I understand, this is valid GLSL. It is okay to define overlapping bindings, so long as a given compiler shader ("version") only uses one or the other (I don't know if that is a static constraint or a dynamic one).
from slang.
Is it valid even if the declarations are in the same shader?
Issue #96 both the constant-buffer and sampler are bound to the same location and are being used in the shader, I don't see why this is valid.
I'm not suggesting Slang is doing anything wrong. Either glslang has a bug or GLSL has a bug.
from slang.
Do we get errors reported from the driver?
I would need to comb the spec carefully to know what is or isn't valid.
from slang.
I implemented a basic version of this in #118. I'll close this if/when I get confirmation that it seems to meet requirements (and doesn't give false positives).
from slang.
I've seen this trigger now in cases where it should, and nobody has reported false positives (yet), so I'm going to consider this good.
from slang.
Related Issues (20)
- Consider supporting #pragma pack_matrix() HOT 1
- Capability System: Profile and look into performance with larger systems
- Metal: support integer type texture
- Fix memory leak in slang.dll HOT 2
- Create the breakdown profiling of slang HOT 2
- AD Cleanup: Use a temporary accumulation inst such as `IRAccumulate` instead of explicitly loading, adding and storing differential values in reverse mode HOT 1
- Implement metrics tracking for GitHub engagement
- Document the existing auto-diff type system, semantic checking and AST synthesis methods
- Return ptr of new Object out of Slang DLL HOT 5
- Stage the CTS cases known failure for now. HOT 1
- Fix CTS tests failures.
- Breakdown the runtime cost of Slang backend passes.
- constexpr doesn't work as expected when used on a function HOT 3
- Design documentation for DXIL linking of shader-modules
- Pointer example on User Guide doesn't work HOT 5
- Incorrect inlining of generic initializers HOT 1
- Throw an error when using `[[vk::binding]]` on global shader parameters
- Wrong matrix operations in Metal? HOT 6
- How to import modules :) HOT 1
- support for opengl HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slang.