Comments (6)
It's possible that it works fine, but thread safety problems have a nasty habit of sneaking up on you in ways that are tricky to predict. At minimum I would restart it regularly, since any issues in syncing would presumably accumulate over time.
I would have assumed the queue solved it as well, but I was surprised to learn that pandas is not thread safe even when conducting read-only operations. How that is possible I have no idea, but so says stackoverflow.
from binancebalance.
Interesting! I never actually ran the Python 2 version, I immediately edited the program for Python 3.
from binancebalance.
Yea, I can maintain a 15 coin portfolio with room to spare in the python2 version, in python3 it can't keep up. Must be some tkinter backend changes between the versions.
It's a good excuse to learn multithreading (thanks for your example code, it will be immensely helpful) - but because pandas is not threadsafe I will have to refactor it drastically. I don't know how that lack of thread safety will manifest itself here, but I suspect it means that the GUI will diverge from reality over time, so please be careful using the threaded version to execute trades, as it may not be operating with the right information.
from binancebalance.
Some of the issues may also relate to the python-binance code, which it appears from their README (https://github.com/sammchardy/python-binance) may not be 3.7 compatible in its entirety. I notice that requests to binance through them are noticeably slower, so that might be the source of the issue. I may try 3.6 to see if it is better, since they say is supports 3.6.
from binancebalance.
Thanks for the heads up! I thought that the message queue would have solved any thread safe issues. Ill look into it further. I have been comparing the GUI data to the Binance app quiet regularly looking for any discrepancies but didn't notice anything unusual.
Obviously, feel free to refactor anything you need. After all its your show. Ill be looking out for any changes :)
from binancebalance.
Some of the issues may also relate to the python-binance code, which it appears from their README (https://github.com/sammchardy/python-binance) may not be 3.7 compatible in its entirety. I notice that requests to binance through them are noticeably slower, so that might be the source of the issue. I may try 3.6 to see if it is better, since they say is supports 3.6.
This seems very plausible.
from binancebalance.
Related Issues (4)
- Help with Customization HOT 6
- The websockets doesnt run. HOT 3
- great project HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from binancebalance.