ISSUE: No $pnp or pnp global object when using in Visual Studio (not Visual Studio Code) about pnp-js-core

[patrick-rodgers]

This syntax works for me:

/// <reference path="pnp.d.ts" />
import PnP = require("pnp");

The first line gives the ref to the typings file and the second is the actual "import" into your code. Please confirm and we can close the issue.

[alex-randall]

Thanks Patrick, will try and report back.

[patrick-rodgers]

So it looks to me that we would have to produce a set of es6 *.js files in the lib package and then have a separate build path for the pnp.js file that produces UMD. I guess I'll take a look at this one, which puts samples on the back burner unfortunately.

[alex-randall]

Cool thanks @patrick-rodgers. Sounds like that might handle the es6 side of things. We'll see how it goes.

Maybe related questions:

1. I could be wrong and old school, but doesn't the import PnP = require("pnp"); syntax requires a (typing and runtime) dependency on requirejs? I thought we didn't have any dependencies (at runtime) other than things that SharePoint itself provides on a SharePoint page?

2. Also shouldn't the naming of the alias in something like: import {$pnp} = from 'whateverwenameit';
   be $pnp so it can be used in all TypeScript documentation/samples since that's what is the global name ends up being in JavaScript? Reason being: it make samples and documentation much easier to write for both TypeScript and JavaScript because the same $pnp entity can be referenced from whatever way you are including it. Otherwise, the JavaScript and TypeScript samples and documentation will deviate radically with different "root variables" (PnP, $pnp). Thoughts?

[patrick-rodgers]

1. Updated in #75, now supports:

import pnp from "sp-pnp-js";

Please validated with latest npm package 0.0.10.

2. You can name it whatever you want when you import.

[mike-morr]

@patrick-rodgers New package is not working in jspm (and I suspect npm as well since jspm is simply downloading the npm package).

Here is the top of pnp.js that was downloaded from the 0.10 (confirmed in package.json) npm package.

It doesn't look like it got transpiled to ES5

/* */ 
"format cjs";
"use strict";
import * as Util from "./utils/Util";
import { SharePoint } from "./SharePoint/SharePoint";
import { PnPClientStorage } from "./utils/Storage";
import * as Configuration from "./configuration/configuration";
import { Logger } from "./utils/logging";
import { Rest } from "./SharePoint/Rest/rest";

[mike-morr]

Forgot to mention, Intellisense was working out of the box this time though.

[patrick-rodgers]

The code in /lib is es6 to support the es6 syntax. The code in the dist folder is es5 in a umd module and should be used in the browser.

[patrick-rodgers]

package updated to maintain the default export we desire for umd modules in the browser in #80. @alex-randall please test, would like to get this one closed.

[pr0peller]

Hi,
I just want to say that I test the library in ASP.Net application:

///<reference path="../node_modules/sp-pnp-js/dist/pnp.d.ts"/>
import * as Pnp from "pnp";
works,

///<reference path="../node_modules/sp-pnp-js/dist/pnp.d.ts"/>
import Pnp = require("pnp");
works also.
I have tested it also in Nodejs typescript application and it works the same way.
Dev env: Visual Studio 2015 Enterprise Update 2
Would be great if somebody else confirm the results.

[patrick-rodgers]

This appears to be fixed, thanks all.