Should the mock classes be refactored out of main library? about pnp-js-core

[pbjorklund]

I don't think this is "small", it's a very valid point. Anything purely related to tests should not be part of the dist. @patrick-rodgers has started the work on moving tests out from the old structure where each .ts file had a matching tests.ts file. See the sharepoint/rest/tests folder.

What about using the same structure as https://github.com/Microsoft/TypeScript with a separate /test folder under the root of the library?

I would volunteer to make sure that all tests are moved to /tests and that for instance gulp is updated to work against that structure.

[patrick-rodgers]

This is something we talked about in early days and folks felt like having the .test.ts file along side the .ts file made it clearer and more obvious. At the time I agreed, but now that we have already grown and will continue to grow I am leaning towards moving to a separate test folder. I think it would be cleaner and reduce the "clutter" in the src folders. If you want to commit to moving things and updating the associated test gulp tasks that would be great, @pbjorklund .

[pbjorklund]

#62 handles this.

[patrick-rodgers]

Closing this as it was indeed resolved by #62. Great work by @pbjorklund on this.