Remove remaining jQuery refs in src about pnp-js-core

[mike-morr]

@biste5 @patrick-rodgers I don't think we need a custom function. We can just use the built-in array.filter.

[alex-randall]

Agreed! We need to have as few dependencies as possible so the widest array of people can use it. Some companies have very specific restrictions on using "library x" or not.

[biste5]

I am looking into this, and seems the strongest dependencies on jQuery are on the provisioning part.

Unfortunately, this isn't covered by tests, and I don't know how to test it at the moment.

Fix to change after a quick look:

• remove jQuery.ajax calls: just one, it's basically done reusing HttpClient
• replace jQuery.grep with a custom utility function, which should be called grep or fiter (any preference?). Does it have to be IE8 compatible?
• remove remaining references of jQuery.Deferred

I have started, but not sure how far I can go in the next few days; also because first of all I think I'll try to write few tests to cover existing lacks in methods to adjust.

Let me know if I should issue a WIP PR or how to best handle this

[patrick-rodgers]

Thanks for taking a look, that seems like a good list, I didn't think there was too much left. As for IE8 - no, don't worry about it. If someone needs IE8 support they can log a bug and we can revisit.

[biste5]

Thanks @mike-morrison and @patrick-rodgers !

[biste5]

I've covered I think 80% of the stuff, it's pushed atm to
https://github.com/biste5/PnP-JS-Core/tree/dev_74

What remains it's all in objectfiles.ts

• jQuery.get to get raw content of a file (line 25), and definition of a web part (Line 100) (?)
• jQuery.when.apply at Line 31, looks a bit fragile to me, and I didn't know yet how to convert it to Promise safely
• jQuery.extend, mainly at Line 179. (That one at line 27 can be easily rewritten using vanilla JS)

[patrick-rodgers]

Closing this, nice work Massimo.