GithubHelp home page GithubHelp logo

Comments (4)

sharksforarms avatar sharksforarms commented on May 4, 2024

I wonder if the assert could be done at compile time? Currently the assert is done at runtime which isn't ideal... For example, this would fail to compile (attempt to store 9 bits in 8 bit container)

struct DekuTest {
    #[deku(bits = "9")]
    field_a: u8,
}

from deku.

elast0ny avatar elast0ny commented on May 4, 2024

This should be possible with https://docs.rs/static_assertions/1.1.0/static_assertions/macro.const_assert.html if you make the bit_size() function const

from deku.

elast0ny avatar elast0ny commented on May 4, 2024

dam rust-lang/rust#57563 , i really thought const fn were stable for some reason...

I guess traits cannot contain const fns

const fn bit_size() -> usize;
   |     ^^^^^ trait fns cannot be const

It seems like bit_size() is just wrapping std::mem::size_of which is a const fn so maybe instead of having a bit_size trait, you could just call size_of() directly on the type ?

from deku.

sharksforarms avatar sharksforarms commented on May 4, 2024

No longer required: #19

from deku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.