Comments (10)
Nice - thanks for the tip!
I won't be able to get a change out right away, but I also won't stand
in the way of pull requests. :-D
On Jun 15, 2012, at 17:34, Wesley Beary
[email protected]
wrote:
See: https://github.com/heroku/manager-cli/blob/master/lib/heroku/command/manager.rb#L3
The heroku gem doesn't depend on json and plugins don't install gems so this can cause issues. Particularly it is problematic in the case of toolbelt stuff due to the way gems are handled there. It would be better to use the vendored json capabilities in heroku, which can be used via
Heroku::OkJson.decode()
andHeroku::OkJson.encode()
.Hopefully thats clear and should be straightforward to change, but let me know if you have questions or need help. Thanks!
Reply to this email directly or view it on GitHub:
https://github.com/shayfrendt/heroku-ranger/issues/3
from heroku-ranger.
@shayfrendt - sure thing. I don't think there is any particular hurry, but it was causing segfaults for some people using toolbelt (I wasn't able to reproduce, but anyway) thought I would pass it along so you would be aware.
from heroku-ranger.
I just ran into this issue - I'm using the downloadable Toolbelt and installing the json gem made no difference. No segfaults, but the ranger plugin wouldn't install.
from heroku-ranger.
@RandomEtc - using the gem should allow you to get around this until a fix is available.
from heroku-ranger.
@RandomEtc - more specifically, using the heroku gem (rather than toolbelt) should let you get around this.
from heroku-ranger.
Unfortunately using the Heroku Toolbelt was the recommended solution for some other issues I had with the gem :) If I decide to look at this again I'll fork the plugin and fix it for the Toolbelt.
from heroku-ranger.
@RandomEtc - ah. got it. It should be a pretty straightforward fix, but let me know if you give it a shot and have trouble.
from heroku-ranger.
Here ya go: #5
from heroku-ranger.
@m1foley Awesome - thanks sir. I'll try that out and get it merged down to master shortly.
from heroku-ranger.
Aight this should be all working correctly now via #5.
from heroku-ranger.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroku-ranger.