GithubHelp home page GithubHelp logo

Comments (4)

arturadib avatar arturadib commented on May 22, 2024

Yeah I debated over this, ended up going with the hash because for (file in ls()) was closer to Bash's for loop and less verbose than .forEach(function(file){ ... }), but I agree that arrays are more powerful.

Let's gather some thoughts from other folks.

from shelljs.

arturadib avatar arturadib commented on May 22, 2024

@tkazec actually, if you're still up for it, I'd love to see a pull request that changes the result of ls() and find() to array. this might take a bit of work to make all tests pass though (via ./scripts/run-tests.js), since the tests make use of hash results (like 'filename' in ls()).

I'll dig a bit deeper once we have a pull request.

thanks!

from shelljs.

arturadib avatar arturadib commented on May 22, 2024

actually I took a quick stab at it this morning 88292ea

thanks anyway!

from shelljs.

tkazec avatar tkazec commented on May 22, 2024

Awesome! I was going to do it last night but ended up being unavailable. Looks good!

from shelljs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.