Comments (2)
Invalid. pointsCorrection
makes sure that cumulativeRewardsOf(_account)
is always greater than withdrawnRewards[_account]
.
from 2022-10-merit-circle-judging.
This error does not happen because of what jack-the-pug commented. If there is any evidence of this error happening, please provide additional information or a code snippet.
from 2022-10-merit-circle-judging.
Related Issues (20)
- WATCHPUG - First user can inflate `pointsPerShare` and cause `_correctPoints()` to revert due to overflow HOT 5
- HonorLt - Receiver might not support deposits
- ignacio - RETURN VALUES OF TRANSFER()/TRANSFERFROM() NOT CHECKED
- WATCHPUG - Front run `distributeRewards()` can steal the newly added rewards HOT 3
- WATCHPUG - `escrowedReward` will be frozen in the contract if `escrowPool == address(0)` but `escrowPortion > 0` HOT 3
- WATCHPUG - Expired locks should not continue to earn rewards at the original high multiplier rate HOT 3
- WATCHPUG - Extend lock period should never result in a decrease of overall rewards (`total length of locked period * shares`) HOT 3
- ElKu - extendLock function in TimeLockPool contract overwrites previously accumulated token shares HOT 1
- WATCHPUG - Curve points should be guaranteed to be monotonic increasing HOT 3
- TomJ - User will Lose Rewards by `extendLock()` of `TimeLockPool.sol` HOT 1
- WATCHPUG - Lack of deadline control in `deposit()` may result in an unfavorable lock in some edge cases HOT 1
- saian - User will loose rewards if `escrowPool` is set to address(0)
- WATCHPUG - Miscellaneous
- holyhansss - [HIGH] Users will lose funds when expending lock time. HOT 1
- hyh - Maximum duration multiplier can be forced for lock amount increase
- saian - User can receive more rewards by staking for less duration
- ak1 - Curve points calculation is not clear
- hyh - Rewards can be retrieved in a almost flash loan manner
- saian - `withdraw` will revert if user had transferred shares HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2022-10-merit-circle-judging.