bughuntoor - Certain functions should not be usable when `GaugeController` is locked. about 2023-11-convergence-judging

[CergyK]

Escalate

This is an admin function, the admin can be trusted to not call these operations when voting is routinely locked to not interfere with rewards distribution

Moreover, outside of routine cycle increments, it would be a good procedure to lock votes before the admin changes weights, as described in other reported issues such as #122

[Czar102]

I believe the escalation makes a valid point. Planning to consider this issue a low severity one.

[0xR3vert]

Hello,

Thanks a lot for your attention.

Absolutely, if we kill a gauge or change a type weight during the distribution, it would distribute wrong amounts, even though we're not planning to do that. We can make sure it doesn't happen by doing what you said: locking those functions to avoid any problems.

Therefore, in conclusion, we must consider your issue as a valid.

Regards,
Convergence Team

[nevillehuang]

I will keep this as medium as although on first look this could be "admin error", as sponsor mentioned, honest users claiming during killing of a gauge or weight change can result in inaccurate result distribution.

[sherlock-admin2]

Escalate

This is an admin function, the admin can be trusted to not call these operations when voting is routinely locked to not interfere with rewards distribution

Moreover, outside of routine cycle increments, it would be a good procedure to lock votes before the admin changes weights, as described in other reported issues such as #122

You've created a valid escalation!

To remove the escalation from consideration: Delete your comment.

You may delete or edit your escalation comment anytime before the 48-hour escalation window closes. After that, the escalation becomes final.

[nevillehuang]

See comments here

[Czar102]

Result:
Low
Unique

[sherlock-admin2]

Escalations have been resolved successfully!

Escalation status:

• CergyK: accepted

[IAm0x52]

Fix looks good. _setTotalWeight has now been folded inside _checkpoints to avoid this issue