Comments (2)
0xR3vert
commented on July 26, 2024
1
Hello,
Thanks a lot for your attention.
The Locking/YsDistributor contracts are designed to function in the manner observed, which aligns with their expected behavior.
When locking in a cycle before a TDE, a value called ysPartial is created, which is taken into account for that TDE. For the subsequent TDE, it's the ysTotal value that is considered.
It's normal not to receive additional ysCvg & mgCvg when extending the time only. This serves as an incentive for the user to always lock for the maximum time.
Therefore, in conclusion, we must consider your issue as invalid.
Regards,
Convergence Team
from 2023-11-convergence-judging.
nevillehuang
commented on July 26, 2024
Additional duplicates arising from same root cause of extending/increasing lock time no calculating ysCvg/mgCvg correctly:
from 2023-11-convergence-judging.
Related Issues (20)
- ydlee - A token owner cannot remove one mgCvg delegation when he already delegates to `maxMgDelegatees` addresses.
- chainNue - Allowance is not set to zero first before approving
- cducrest-brainbot - Withdrawing rewards will convert sdt to cvgSDT at any rate
- mahmudsudo - empty array input claims rewards HOT 1
- pontifex - Unexpected revert at the `delegateMgCvg` and `delegateVeCvg` when delegation removal
- pontifex - Users can't receive rewards in the actual `cvgCycle` due to unexpected error HOT 11
- zraxx - When `delegateMgCvg` is used for update or remove, it will be reverted due to improper require checks. HOT 1
- pontifex - Tokens distribution may be broken due to incorrect address verification when depositing tokens HOT 1
- 0xmuxyz - The locked-amount and the voting power can still be increased even after the given `tokenId` of locking position NFT (ERC721) would be burned via the LockingPositionService#`burnPosition()` HOT 1
- CL001 - In the case that the total supply of CVG tokens is insufficient, the last user to claim the rewards will suffer a loss HOT 2
- jah - a malicious user can prevent a user from receiving a delegation
- bitsurfer - Did not approve to zero first issue
- bitsurfer - Possible DoS happening when gauge weight is changing due to underflow of `pt.slope -= d_slope`
- jah - wrong time when increasing the locking time HOT 1
- lemonmon - `LockingPositionService.mintPosition()` problems with duplicate `tokenIds` from `LockingPositionManager` may cause users to lose their funds HOT 3
- qpzm - Out-of-gas error in `CvgERC721TimeLockingUpgradeable.getTokenIdsForWallet` HOT 1
- Inspex - If admin kill a gauge, user’s voting power for that gauge may lost 1 or 2 cycles HOT 1
- hash - Possible loss of unclaimed rewards for long-term frequent stakers
- GimelSec - `SdtStakingPositionService.processSdtRewards` could record the wrong amount of sdt reward.
- jah - wrong calculation which leads to a not being able to function properly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2023-11-convergence-judging.