mstpr-brainbot - When governance burns an NFT, the claimable balances of other NFT can be mixed about 2024-01-telcoin-judging

[amshirif]

@nevillehuang No there was only one fix. Essentially, since they were being burnt incorrectly it also meant rewards would not be calculated correctly. Therefore, fixing how they were burnt fixed both issues.

[amshirif]

This issue has a common fix with #6

[amshirif]

https://github.com/telcoin/telcoin-audit/pull/31

[sherlock-admin2]

1 comment(s) were left on this issue during the judging contest.

takarez commented:

valid because {It is also a dupp of (14) as watson was able to show how popping will lead an issue but of mixed accounting in this case}

[nevillehuang]

Hi @amshirif couple of questions to clarify if this can be a duplicate of #36

• Is the affected lines of code to this issue identical to #36
• Even though the fix is from the same pull request, was there 2 separate fix introduced?

[nevillehuang]

@amshirif I think #199 is the most comprehensive submission, so I will make it the best report. Could you add the relevant sponsor confirmed and will fix tags along with the fix PR? Thanks alot!

[sherlock-admin]

The protocol team fixed this issue in PR/commit https://github.com/telcoin/telcoin-audit/pull/31.

[sherlock-admin]

The Lead Senior Watson signed off on the fix.