Comments (7)
amshirif
commented on June 27, 2024
1
Not sure how to label this one. The issue mentioned is not actually an issue. However it did reveal that some way to remove approvals. The reason it's not an issue is because approvals should be maintained between owners. The approvals are for specific addresses who have some level of ownership of the council seat.
from 2024-01-telcoin-judging.
amshirif
commented on June 27, 2024
https://github.com/telcoin/telcoin-audit/pull/33
from 2024-01-telcoin-judging.
sherlock-admin2
commented on June 27, 2024
1 comment(s) were left on this issue during the judging contest.
takarez commented:
invalid because { This is invalid because transfer is not allow; admin dosnt need to approve a user thats the main thing behind overridden it to allow approval only in case of emergnecy or something}
from 2024-01-telcoin-judging.
nevillehuang
commented on June 27, 2024
request poc
from 2024-01-telcoin-judging.
sherlock-admin2
commented on June 27, 2024
PoC requested from @mstpr
Requests remaining: 12
from 2024-01-telcoin-judging.
sherlock-admin
commented on June 27, 2024
The protocol team fixed this issue in PR/commit https://github.com/telcoin/telcoin-audit/pull/33.
from 2024-01-telcoin-judging.
sherlock-admin
commented on June 27, 2024
The Lead Senior Watson signed off on the fix.
from 2024-01-telcoin-judging.
Related Issues (20)
- grearlake - `SUPPORT_ROLE` can steal TELCOIN by calling `recoverERC20FromStaking()` function HOT 1
- sonny2k - Missing check if the sum of amounts value in array equals to totalWithdrawl in proposeTransaction() HOT 1
- m4ttm - Burning any CouncilMember other than the last can prevent minting HOT 1
- ggg_ttt_hhh - There is a misuse of indices input in the topUp function. HOT 1
- kgothatso - `TelcoinDistributor : : executeTransaction ` internal Reentrancy by Council Member HOT 2
- araj - staking contract with different rewardToken can be added in stakingContractManager HOT 2
- Avci - there is a wrong require check in `executeTransaction` revert for expiration of challenge. HOT 2
- BAICE - CouncilMember NFT still support `setApprovalForAll` , `safeTransferFrom` `transferFrom` methods HOT 5
- sonny2k - Removing the item in array without preserving the array index making other functions unusable in CouncilMember.sol: burn() and StakingRewardsManager.sol: removeStakingRewardsContract() HOT 1
- 0xlucky - In function topUp() staking.setRewardsDuration() allows setting near zero or enormous `rewardsDuration`, which breaks reward logic HOT 2
- m4ttm - Users balances are incorrectly swapped when a CouncilMember is burned HOT 1
- kgothatso - `TelcoinDistributor :: ` out of gas can lead to DOS HOT 1
- grearlake - Latest council member will lost rewards after burning council member NFT HOT 1
- sonny2k - mint() function using totalSupply() as the id for newly minted NFT will always be reverted if some NFTs were burnt HOT 1
- Avci - the `batchTelcoin` will always fail due to wrong check in require. HOT 1
- m4ttm - Approvals persist when a CouncilMember is burned and the id is later reminted HOT 1
- kgothatso - `TelcoinDistributor :: proposeTransaction ` Council Member can steal all funds HOT 1
- 0xlucky - StakingRewards: Significant loss of precision possible HOT 2
- grearlake - Malicious builder can back-run to update malicious config of staking contrat when deploying HOT 2
- zhuying - [M-01] The burn function will break the claim function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2024-01-telcoin-judging.