Colors don’t match VS Code about shiki

[octref]

Soon, doing the release preps.

[leafac]

Awesome. This is perfect now. One more time: Thank you very much for this project!

[octref]

You are right, it seems to be using color of light theme, not light plus.

[leafac]

That’s what I thought too. Why is this happening? How can I help investigate?

[leafac]

Another case. Note the {} and the ; on the output type:

Visual Studio Code

(Ignore the red squiggly.)

Shiki

Program Used to Produce Shiki Output

const shiki = require("shiki");

shiki
  .getHighlighter({
    theme: "light_plus",
  })
  .then((highlighter) => {
    console.log(
      highlighter.codeToHtml(
        `function f(): { key: Type; otherKey: otherType } {}`,
        "ts"
      )
    );
  });

[octref]

Upgrade to 0.1.7, which includes the updated Light+ theme.

[leafac]

Thank you.

I tried both cases I reported and only the second is fixed. The return in return 'shiki'; still shows up in blue, not pink like I see in VS Code.

[octref]

Probably, I need to update the grammar as well 😅

[octref]

Seems fixed:

const shiki = require('shiki')

shiki.getHighlighter({
  theme: 'light-plus'
}).then(highlighter => {
  console.log(highlighter.codeToHtml(`return 'shiki';`, 'js'))
  console.log(highlighter.codeToHtml(`function f(): { key: Type; otherKey: otherType } {}`, 'ts'))
})

[leafac]

I suppose you haven’t released the fixed version to npm yet, because my original example still shows return in blue and your example above fails as the theme is called light_plus, not light-plus. When do you plan on releasing the fixed version?