Comments (3)
Would it make sense to detect this in the calling thread and if the object is
too large not even bother the IO
thread? Since the encoding is done by the caller this should be straight
forward.
An open question is what to do if the object is too large. A few options I can
think of:
o throw an exception immediately
o throw an exception in Future.get wrapped in a ExecutionException
o have Future.get return false
In my code I usually do not wait for a store operation, thus only the first
option would allow me to detect this
case. Throwing an exception in a production environment does not seem like a
good idea, however, so
perhaps it makes sense to have one of the latter options be the default, but
allow the first option to be
enabled via a flag?
The disadvantage of returning false is that no reason for the failure can be
given, while an exception allows
this to be communicated. Since ExecutionException is checked it might make
sense to use it in this case (the
client has to handle it anyway).
Original comment by [email protected]
on 2 Oct 2008 at 5:48
from spymemcached.
Original comment by [email protected]
on 2 Oct 2008 at 7:03
- Added labels: Milestone-Release2.2
- Removed labels: Milestone-Release2.1
from spymemcached.
I ended up with #1. An IllegalArgumentException will be thrown on any
set/add/replace/cas/whatever at the time of encoding. You can increase the
size in
the client (I needed this functionality to maintain coverage in the tests
anyway).
Original comment by [email protected]
on 3 Oct 2008 at 3:40
- Changed state: Fixed
from spymemcached.
Related Issues (20)
- State the dependencies in the pom file HOT 5
- Multhreaded implementation with SASL support not working. HOT 1
- Operation class is used in un-threadsafe, unsynchronized manner. HOT 4
- Inside TCPMemcachedNodeImpl, use direct buffers HOT 4
- Stability problems in async I/O HOT 4
- assertion failure during ConsistentHashingTest HOT 1
- incr/decr parameter "by" should be a long, not an int HOT 9
- Zlib encoding/binary access HOT 3
- getBulk() logs a warning when no keys are in the cache HOT 3
- bug in OperationImpl HOT 6
- get(long timeout, TimeUnit unit) may take longer than given timeout HOT 3
- IllegalArgumentException after Switching from SpyMemcached 2.7 to 2.7.1 HOT 2
- "unl" unlock operation is not implemented on MembaseClient HOT 9
- 2.7.1 jar for download corrupt? HOT 5
- Callback support HOT 11
- Get canceled HOT 5
- CAS operation fails due to client sign-extending the CAS value HOT 1
- warning for "handling node for operation is not set" if any server is down HOT 4
- javadoc warnings from tap and vbucket classes HOT 3
- CASMutator removes expiry on mutated items
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spymemcached.