Questions get duplicated when the message is too long about cli-ui

[lugray]

Ah, yes, that makes sense. I'd be happy to review a PR that fixes this.

[ChrisBr]

Is there any workaround for this? e.g. can we query the allowed terminal size / characters before this breaks?

[lugray]

You can:

cli-ui/lib/cli/ui/terminal.rb

Lines 21 to 23 in 12ecafb

	def width
	winsize[1]
	end

I'd still love to review a PR that fixes it properly though.

[ChrisBr]

I'd still love to review a PR that fixes it properly though.

Yeah I would love to have this fixed, I'm just not really familiar with this library. Might give it a go though.

[ChrisBr]

With long selects it also duplicates (triples) entries and messes the screen up completely. I suppose that's related.

@lugray any pointers where to look in first / what might go wrong here?

[lugray]

They are separate but similar bugs. In both cases, we're assuming that things are on a single line that may not be. For the original issue, after a response is chosen, we rewrite the question with the chosen response. We prepare to do this by clearing the previous line of the terminal:

cli-ui/lib/cli/ui/prompt.rb

Lines 265 to 268 in 151f207

	# Clear the line
	print(ANSI.previous_line + ANSI.clear_to_end_of_line)
	# Force StdoutRouter to prefix
	print(ANSI.previous_line + "\n")

If the question were on a single line, this would be fine. But when the question spans multiple lines, we erase only the last one.

The second bug you identified at a guess is a bug in

cli-ui/lib/cli/ui/prompt/interactive_options.rb

Line 108 in 151f207

def calculate_option_line_lengths

I think a single choice is wrapping to a new line, but there are also more choices than space available to display them, so we're trying to track the number of lines available, and elide choices at the top/bottom of the list, but the wrapped line is disturbing our count of number of lines available.