Comments (5)
@lastgabs and I discussed this on the pod hangout and I suggested she try adding the in-repo gems to the load_paths
in packwerk.yml
and see what happens. She’s going to do that shortly and report back.
from packwerk.
(Maybe I should’ve suggested package_paths
instead. The distinction is not very clear to me.)
from packwerk.
I investigated how to decouple from zeitwerk and documented the findings in Shopify/constant_resolver#26.
Seems actually like using Sorbet is the best bet, but that would be a major rewrite of packwerk. Might still make sense at some point.
from packwerk.
This is an older issue but also wanted to link #218 which provides an implementation for and interesting discussion around allowing packwerk to work in any gems that use zeitwerk for autoloading!
from packwerk.
Hey, I just wanna ask for any updates on this.
I face it during the research for trying to enforce boundaries of external gem with package.yml config.
I.e. Gemfile includes any external gem and this gem has package.yml
file with a public interface, and I want to enforce privacy violations for that external gem. I thought it possible via extension config, but it's not, and packwerk validate
getting failed due to relative paths checks, even if I put explicitly absolute path to main package.yml file:
dependencies:
- ../my_external_gems/my_gem
and packwerk update-todo
also cannot catch violations from external gem as well, even with Zeitwerk::Loader.eager_load_all
setup. So I think this issue is exactly about it (in terms of other dependencies
). Is it in the plans?
from packwerk.
Related Issues (20)
- [Packwerk 3.0] Ensure API boundaries are up-to-date HOT 1
- [Bug Report] Syntax error when rendering two partials HOT 1
- [Bug Report] Runtime Error after running packwerk check HOT 1
- Packwerk thinks that `app/helpers/foobar_fizz.rb` is in the package `app/helpers/foobar` and not `app/helpers`
- [Bug Report] Stale violations on deleted files HOT 1
- [Bug Report] - Packwerk::NodeHelpers::TypeError HOT 3
- [Bug Report] deprecated_references.yml files erroneously removed if running `packwerk update-deprecations` with the `--package` argument
- [Bug Report] Behaviour of enforce_dependencies: key missing HOT 1
- [Bug Report] Improve strict mode HOT 2
- [Bug Report] Insufficient release notes HOT 2
- [Bug Report] packwerk is disabling Sorbet runtime checks, globally on Spring
- [Bug Report] Disable sorbet when using spring
- [Feature Request] Detect stale todos HOT 1
- [Bug Report] Exception when loading signatures
- [Bug Report] Default require behaviour
- [Bug Report] Dependency violation not detected when using public folders or in non-public folder with dependencies specified HOT 1
- [Feature Request] Allow configuration of `package_todo.yml` violation destinations HOT 4
- [Feature Request] Separate run-time and test-time dependencies HOT 11
- [Bug Report] HOT 2
- [Bug Report] bundler: failed to load command: packwerk HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from packwerk.