Saving variants returns ResourceNotFound error about shopify_python_api

[drwelby]

Looks like we need to overload the save method to update the prefix_options with the product id:

https://github.com/drwelby/shopify_python_api/blob/master/shopify/resources.py#L115-L117

[drwelby]

Also a Product.add_variant(variant) seems handy:

https://github.com/drwelby/shopify_python_api/blob/master/shopify/resources.py#L106-L108

[kevinhughes27]

hi there, thanks for opening an issue. I took a look and the way you want to do this is like so
v = shopify.Variant({'product_id':632910392})

I realize this isn't super intuitive but I hope this solves your problem

[drwelby]

Isn't that the same thing as

v = shopify.Variant()
v.product_id = 632910392

Since in the one-liner you're setting the attribute via pyactiveresource's _update, and in the two-liner via setattr ?

There's been updates to both the python api and pyactiveresource since I filed the pull request, so maybe it's working now anyway? I'll give it a try.

[kevinhughes27]

I would have thought so but it didn't work for me.

[drwelby]

Seems like the dict you're passing is getting used as prefix_options (where it's needed) and not as the variant's attributes (which is the more intuitive action). No idea why, though.

def __init__(self, attributes=None, prefix_options=None):

( https://github.com/Shopify/pyactiveresource/blob/master/pyactiveresource/activeresource.py#L351)

[kevinhughes27]

yeah that is weird. We're planning to move away from activeresource and pyactiveresource for api libraries eventually.

[drwelby]

I'll poke around with it more this weekend, but it seems like this would let it work either way:

https://github.com/drwelby/shopify_python_api/blob/master/shopify/resources.py#L119-L122

[kevinhughes27]

That looks like it might be the fix, feel free to make a PR after you play around with it a bit

[drwelby]

How are you running your unittests? I want to add some additional coverage for my changes but I can't get them to run the way I usually do.

[kevinhughes27]

you can run the tests with
python setup.py test