GithubHelp home page GithubHelp logo

Comments (3)

rafaelfranca avatar rafaelfranca commented on May 28, 2024

Thank you for the issue. Are you able to open a PR adding some configuration to the timeout of the client? I'd like to avoid adding faraday as a dependency of the gem since I don't think it is necessary just yet.

from smart_todo.

rzaharenkov avatar rzaharenkov commented on May 28, 2024

Sure, I can do it. Btw, I have just found there is similar code for slack API but it actually has timeouts:

https://github.com/Shopify/smart_todo/blob/master/lib/smart_todo/slack_client.rb#L30-L31

Do you think we have to use different configs for rubygems/slack or just provide generic HTTP client options? It could be handy to configure it separately but I think in the most of cases consumer of this code doesn't care. So I'd keep it simple with single config.

For the options itself we also have few options:

  • configure options as Hash;
  • allow to configure a lambda that should be executed after client is built;
  • allow to configure a lambda that should accept the URL and build an instance of Net::HTTP;

I'd prefer to keep it simple and use a Hash.

from smart_todo.

rafaelfranca avatar rafaelfranca commented on May 28, 2024

Single option as a Hash is a good start to me. If we need to build something more complicated users will ask for it.

from smart_todo.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.