Comments (3)
Thank you for the issue. Are you able to open a PR adding some configuration to the timeout of the client? I'd like to avoid adding faraday as a dependency of the gem since I don't think it is necessary just yet.
from smart_todo.
Sure, I can do it. Btw, I have just found there is similar code for slack API but it actually has timeouts:
https://github.com/Shopify/smart_todo/blob/master/lib/smart_todo/slack_client.rb#L30-L31
Do you think we have to use different configs for rubygems/slack or just provide generic HTTP client options? It could be handy to configure it separately but I think in the most of cases consumer of this code doesn't care. So I'd keep it simple with single config.
For the options itself we also have few options:
- configure options as Hash;
- allow to configure a lambda that should be executed after client is built;
- allow to configure a lambda that should accept the URL and build an instance of
Net::HTTP
;
I'd prefer to keep it simple and use a Hash.
from smart_todo.
Single option as a Hash is a good start to me. If we need to build something more complicated users will ask for it.
from smart_todo.
Related Issues (18)
- Find a way to generate a github link to the todo
- "TODO(username):" pattern HOT 3
- Support multiple file types HOT 1
- Support running bin locally with no credentials HOT 1
- Add an example in the wiki to demonstrate how to run on an array of paths HOT 1
- Crash when parsing quadruple pound HOT 1
- Does our assumption that todo comments are inlined hold in practice? HOT 1
- Enforce smart_todo comment by providing a rubocop cop HOT 1
- Add the `OnPullRequestClosed` and `OnIssueClosed` events HOT 1
- Crash on # TODO? HOT 1
- Implement plugins for assigment
- Support FIXME and OPTIMIZE tags
- Link to the line of the TODO in the notifications HOT 1
- Support branch event HOT 2
- Add a `OnVersionBump` event
- sdhasdh HOT 1
- Add a `OnOccasionaly` event HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smart_todo.