GithubHelp home page GithubHelp logo

Comments (8)

shortcuts avatar shortcuts commented on June 30, 2024 1

I confirm that the q! is fixed. The resize still happens to me. Just to be sure, it also happens to you, right? Or is it something on my side?

If it helps, there seems to appear a white dot in the upper right corner of NNP when the resize happens.

Yes I managed to repro on a big screen but not on my laptop, I guess when I compute the remaining width, there is a .5 offset that sometimes gets rounded or floored, which I'll try to fix also but separately

from no-neck-pain.nvim.

shortcuts avatar shortcuts commented on June 30, 2024

Referencing your comment here @vinoff as I now properly understood the issue, I believe I can fix that before the next major.

from no-neck-pain.nvim.

shortcuts avatar shortcuts commented on June 30, 2024

@vinoff would you mind giving a shot to #364 and highlight if something still bothers you?

from no-neck-pain.nvim.

vinoff avatar vinoff commented on June 30, 2024

@shortcuts, yes! But there is something weird going on, try to reproduce on your end please:

  • Open file and edit something.
  • Do not save.
  • do :q
  • NNP gives an error that it is unable to quit (which is the right way!)!
  • NNP changes size??

This last point is weird.. It seems like NNP width decreases.. A small amount, but still. Does this also happen on your end?

It only happens on the first :q though. If I keep doing :q :q :q :q, the size remains constant. But the first :q does change size. I wonder if there is some other plugin that is causing it.

from no-neck-pain.nvim.

vinoff avatar vinoff commented on June 30, 2024

There is a nasty bug @shortcuts:

  • Open nvim (I mean nvim itself, not a file. Just do "nvim", without a file path)
  • Edit the window (just add some random text, whatever).
  • Do not save.
  • Do :q!
  • It doesn't close. It should close, since you are doing "!".

EDIT: :qa! works though. But :q! should work also.

from no-neck-pain.nvim.

shortcuts avatar shortcuts commented on June 30, 2024

There is a nasty bug @shortcuts:

  • Open nvim (I mean nvim itself, not a file. Just do "nvim", without a file path)
  • Edit the window (just add some random text, whatever).
  • Do not save.
  • Do :q!
  • It doesn't close. It should close, since you are doing "!".

EDIT: :qa! works though. But :q! should work also.

Thanks for trying the fix!! this one should've been fixed, for the other resize issue, I'm not able to consistently reproduce it but it might not directly be related to this fix, as I leverage the same solution as for the init of the plugin, I'll continue to investigate

from no-neck-pain.nvim.

shortcuts avatar shortcuts commented on June 30, 2024

feat released here https://github.com/shortcuts/no-neck-pain.nvim/releases/tag/v1.14.0

from no-neck-pain.nvim.

vinoff avatar vinoff commented on June 30, 2024

There is a nasty bug @shortcuts:

  • Open nvim (I mean nvim itself, not a file. Just do "nvim", without a file path)
  • Edit the window (just add some random text, whatever).
  • Do not save.
  • Do :q!
  • It doesn't close. It should close, since you are doing "!".

EDIT: :qa! works though. But :q! should work also.

Thanks for trying the fix!! this one should've been fixed, for the other resize issue, I'm not able to consistently reproduce it but it might not directly be related to this fix, as I leverage the same solution as for the init of the plugin, I'll continue to investigate

I confirm that the q! is fixed. The resize still happens to me. Just to be sure, it also happens to you, right? Or is it something on my side?

If it helps, there seems to appear a white dot in the upper right corner of NNP when the resize happens.

from no-neck-pain.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.