Comments (7)
As from the module we don't provide any validation of url. You need to implement that on your own.
from protocol-registry.
Can you share your registration code?
from protocol-registry.
const path = require('path');
const ProtocolRegistry = require('protocol-registry');
ProtocolRegistry.register({
protocol: 'testproto',
command: `node ${path.join(__dirname, './index.js')} "$_URL_"`,
override: true,
terminal: true,
script: true
}).then(async () => {
console.log('Success');
});
from protocol-registry.
There was bug in script: true
which is fixed in the current version of the codebase on github.
It has been tested in windows, but testing of macos and linux are pending post which it will be live in npm.
from protocol-registry.
Works now with the changes you made.
Additional question.
Is it secure in terms of malformed URLs being able to execute code on the target machine?
from protocol-registry.
We have added a efficient example to extract data from urls and verify them.
In commit : 2b40053
from protocol-registry.
New npm version live closing this issue.
from protocol-registry.
Related Issues (20)
- MAC documentation is absent.
- Bugs in MacOS
- CheckIfExist function related support app
- Reducing complexity for checkIfExist in macOS
- Documentation Issue in readme.md
- The 'override' option is not working, it still run the prev command HOT 2
- Falsy terminal option registers invalid command on Windows HOT 4
- Deregister URL handler HOT 1
- Deno implementation HOT 1
- Please migrate "all-user-support" into main branch HOT 1
- shelljs throw issue HOT 4
- Remove Shelljs HOT 3
- Problem with spaces in path to script.sh HOT 6
- Let us name the wrapper file. HOT 5
- Handling non-zero exit codes from `xdg-mime` incorrectly interprets absence of protocol as an error on KDE
- Issue when setting another protocol than the demo HOT 1
- Configurable `temp` directory (or support for `pkg`) HOT 1
- Absolute Path of Command is Required on MacOS when Terminal Mode is Off HOT 1
- Use `os.tmpDir()` and allow numbers on protocol
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protocol-registry.