GithubHelp home page GithubHelp logo

Comments (3)

ShukantPal avatar ShukantPal commented on May 18, 2024

@bigtimebuddy Hmm, I did try to ensure a non-zero exit code on failure. The CI does log @pixi/utils failed: - which matches this line. I wonder why the exit code is 0.

https://github.com/SukantPal/pixi-build-tools/blob/812ab6c5e3138cf7e5185436621acb8c4c020c9b/packages/api-extractor-lerna-monorepo/index.js#L99

from pixi-build-tools.

bigtimebuddy avatar bigtimebuddy commented on May 18, 2024

Oh I see, what's going on there, because you set process.exitCode, you are then invaliding that error here:

https://github.com/SukantPal/pixi-build-tools/blob/812ab6c5e3138cf7e5185436621acb8c4c020c9b/packages/api-extractor-lerna-monorepo/index.js#L106

Why not process.exit(1)? or process.exitCode = process.exitCode || 0; later on?

Don't know if this is related but, but it's curious that it reports failed for utils (which is correct), but then show's the stack after starting canvas-display.

@pixi/utils ---------------------------------------------
Analysis will use the bundled TypeScript version 3.9.5
@pixi/utils failed:
Error: The expression contains an import() type, which is not yet supported by API Extractor:
@pixi/canvas-display ---------------------------------------------
/home/runner/work/pixi.js/pixi.js/out/packages/utils/src/index.d.ts:82:12
    at ExportAnalyzer._tryMatchImportDeclaration (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/ExportAnalyzer.js:451:19)
    at ExportAnalyzer.fetchReferencedAstEntity (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/ExportAnalyzer.js:251:45)
    at ExportAnalyzer._tryGetExportOfAstModule (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/ExportAnalyzer.js:496:34)
    at ExportAnalyzer._getExportOfAstModule (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/ExportAnalyzer.js:469:32)
    at /home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/ExportAnalyzer.js:216:60
    at Map.forEach (<anonymous>)
    at ExportAnalyzer._collectAllExportsRecursive (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/ExportAnalyzer.js:207:48)
    at ExportAnalyzer.fetchAstModuleExportInfo (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/ExportAnalyzer.js:157:18)
    at AstSymbolTable.fetchAstModuleExportInfo (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/analyzer/AstSymbolTable.js:63:37)
    at Collector.analyze (/home/runner/work/pixi.js/pixi.js/node_modules/@microsoft/api-extractor/lib/collector/Collector.js:128:57)
Analysis will use the bundled TypeScript version 3.9.5
@pixi/canvas-display: completed successfully!

from pixi-build-tools.

ShukantPal avatar ShukantPal commented on May 18, 2024

Closed with #2

from pixi-build-tools.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.