GO_PACKAGE_STORE_GITHUB_TOKEN doesn't work with Win7 about go-package-store

[klauern]

This is excellent. Thank you for such a quick turnaround. Things seem to be working great on my end.

[dmitshur]

Yeah, you're absolutely right, the GO_PACKAGE_STORE_GITHUB_TOKEN env var only works together with CacheDir, and that was an oversight and unintended!

It's because it checks that env var inside the block when CacheDir is supported:

Go-Package-Store/main.go

Lines 238 to 243 in 7516406

	if cacheDir, err := ospath.CacheDir("github.com/shurcooL/Go-Package-Store"); err == nil {
	diskCache := diskcache.New(filepath.Join(cacheDir, "github-presenter"))
	cacheTransport := httpcache.NewTransport(diskCache)
	// Optionally, perform GitHub API authentication with provided token.
	if token := os.Getenv("GO_PACKAGE_STORE_GITHUB_TOKEN"); token != "" {

Thanks for reporting this problem @klauern, I will fix it tonight! GO_PACKAGE_STORE_GITHUB_TOKEN will be supported independently of CacheDir.

[klauern]

That's great news. I took a look at it and wasn't sure if it was a big change or not.