GithubHelp home page GithubHelp logo

Comments (6)

angelbarrera92 avatar angelbarrera92 commented on June 12, 2024 1

I think that fury-kubernetes-monitoring kubelet ServiceMonitor needs some improving as also kube-prometheus is doing the same.

Uhmmm i see.

So, i will add this task to my todo list. Thanks @lnovara

from fury-kubernetes-service-mesh.

lnovara avatar lnovara commented on June 12, 2024 1

I think it's better to include this patch during the fury-kubernetes-monitoring upgrade.

from fury-kubernetes-service-mesh.

angelbarrera92 avatar angelbarrera92 commented on June 12, 2024

Hi Luca. You're right.

I see the kubelet ServiceMonitor inside the istio offering relabels some metrics:

relabelings:
    - sourceLabels: [job]
      action: replace
      replacement: kubernetes-cadvisor
      targetLabel: job
    metricRelabelings:
    - action: drop
      regex: container_(network_tcp_usage_total|network_udp_usage_total|tasks_state|cpu_load_average_10s)
      sourceLabels:
      - __name__

What should we do with this code block? Merge it into the fury-kubernetes-monitoring kubelet ServiceMonitor?

from fury-kubernetes-service-mesh.

lnovara avatar lnovara commented on June 12, 2024

I think that fury-kubernetes-monitoring kubelet ServiceMonitor needs some improving as also kube-prometheus is doing the same.

from fury-kubernetes-service-mesh.

angelbarrera92 avatar angelbarrera92 commented on June 12, 2024

I think that fury-kubernetes-monitoring kubelet ServiceMonitor needs some improving as also kube-prometheus is doing the same.

I found the commit adding that part: prometheus-operator/kube-prometheus@e4991fe

I can apply this git patch. But... i think it's going to be better to fully upgrade the package. What do you think?

EDIT: https://github.com/sighupio/fury-kubernetes-monitoring/compare/feature/git-patch-kube-prometheus-regenerate?expand=1

from fury-kubernetes-service-mesh.

angelbarrera92 avatar angelbarrera92 commented on June 12, 2024

I think it's better to include this patch during the fury-kubernetes-monitoring upgrade.

Totally agree!

from fury-kubernetes-service-mesh.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.