Library doesn't work with current Signal Desktop about textsecure

[nanu-c]

We can continue to solve the remaining problems that way. If someone does the research in the original signal sources, then it's way more easy for me to provide a solution

[nanu-c]

I think it's a duplicate of nanu-c/axolotl#110

[nanu-c]

i would love it if you find the reason. I thought that textsecure isn't sending the messages to the linked devices and signal server doesn't forward it.

[selfbc]

If this helps, it's from this commit: signalapp/Signal-Desktop@7ca0dfd#diff-0b3c72f8fa053c9f175d037847bb9b32R124

I can give more information as needed.

[morph027]

noticed this too this week:

signal[181]: time="2020/04/06 17:47:24" level=debug msg="[textsecure] SendMessageResponse: {NeedsSync:false Timestamp:1586188043845}\n"

[selfbc]

Yes, the library no longer works with Signal Desktop as of 1.32.0 due to these changes.

[nanu-c]

timestamp is currently set here

textsecure/server.go

Lines 704 to 808 in 306535e

	now := uint64(time.Now().UnixNano() / 1000000)
	m["timestamp"] = now
	m["destination"] = tel
	body, err := json.Marshal(m)
	if err != nil {
	return nil, err
	}
	resp, err := transport.putJSON(fmt.Sprintf(messagePath, tel), body)
	if err != nil {
	return nil, err
	}
	if resp.Status == mismatchedDevicesStatus {
	dec := json.NewDecoder(resp.Body)
	var j jsonMismatchedDevices
	dec.Decode(&j)
	log.Debugf("[textsecure] Mismatched devices: %+v\n", j)
	devs := []uint32{}
	for _, id := range deviceLists[tel] {
	in := true
	for _, eid := range j.ExtraDevices {
	if id == eid {
	in = false
	break
	}
	}
	if in {
	devs = append(devs, id)
	}
	}
	deviceLists[tel] = append(devs, j.MissingDevices...)
	return buildAndSendMessage(tel, paddedMessage, isSync)
	}
	if resp.Status == staleDevicesStatus {
	dec := json.NewDecoder(resp.Body)
	var j jsonStaleDevices
	dec.Decode(&j)
	log.Debugf("[textsecure] Stale devices: %+v\n", j)
	for _, id := range j.StaleDevices {
	textSecureStore.DeleteSession(recID(tel), id)
	}
	return buildAndSendMessage(tel, paddedMessage, isSync)
	}
	if resp.isError() {
	return nil, resp
	}
	var smRes sendMessageResponse
	dec := json.NewDecoder(resp.Body)
	dec.Decode(&smRes)
	smRes.Timestamp = now
	log.Debugf("[textsecure] SendMessageResponse: %+v\n", smRes)
	return &smRes, nil
	}
	func sendMessage(msg *outgoingMessage) (uint64, error) {
	if _, ok := deviceLists[msg.tel]; !ok {
	deviceLists[msg.tel] = []uint32{1}
	}
	dm := createMessage(msg)
	content := &signalservice.Content{
	DataMessage: dm,
	}
	b, err := proto.Marshal(content)
	if err != nil {
	return 0, err
	}
	resp, err := buildAndSendMessage(msg.tel, padMessage(b), false)
	if err != nil {
	return 0, err
	}
	if resp.NeedsSync {
	log.Debugf("[textsecure] Needs sync. destination: %s", msg.tel)
	sm := &signalservice.SyncMessage{
	Sent: &signalservice.SyncMessage_Sent{
	DestinationE164: &msg.tel,
	Timestamp: &resp.Timestamp,
	Message: dm,
	},
	}
	_, serr := sendSyncMessage(sm)
	if serr != nil {
	log.WithFields(log.Fields{
	"error": serr,
	"destination": msg.tel,
	"timestamp": resp.Timestamp,
	}).Error("Failed to send sync message")
	}
	}
	return resp.Timestamp, err
	}
	func sendSyncMessage(sm *signalservice.SyncMessage) (uint64, error) {
	if _, ok := deviceLists[config.Tel]; !ok {
	deviceLists[config.Tel] = []uint32{1}
	}
	content := &signalservice.Content{

and doesn't respect the envelope timestamp. We have to rebuild the message with the correct timestamp

[selfbc]

Looks like the API document hasn't been updated since 2014 - https://github.com/signalapp/Signal-Server/wiki/API-Protocol

[WanderingGlitch]

For what it's worth, modifying the check at https://github.com/signalapp/Signal-Desktop/blob/37ad95af2735f18ed33e9cc5808adae05d542bba/libtextsecure/message_receiver.js#L1378 shows that the envelope does have a timestamp but that the decrypted message does not.

Additionally, commenting out these lines in Signal Desktop allows messages to be received (including the queued ones that haven't been successfully processed): https://github.com/signalapp/Signal-Desktop/blob/37ad95af2735f18ed33e9cc5808adae05d542bba/libtextsecure/message_receiver.js#L1378-L1389

From what I can tell, createMessage needs to set the timestamp in the DataMessage and buildAndSendMessage needs to use the same value

[nanu-c]

Will do that later that week, maybe this evening :)

[nanu-c]

fixed in 6c66a38

[morph027]

Jip, confirmed working, thank you! ❤️

[selfbc]

Everything is going good on my end. Thanks for the speedy work!